Issue 81673 - Draw shapes not displayed after reopening Writer document
Summary: Draw shapes not displayed after reopening Writer document
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: viewing (show other issues)
Version: 680m228
Hardware: PC All
: P2 Trivial (vote)
Target Milestone: ---
Assignee: christian.guenther
QA Contact: issues@sw
URL:
Keywords:
: 82364 83690 84908 84970 85313 85758 (view as issue list)
Depends on:
Blocks:
 
Reported: 2007-09-17 22:42 UTC by Giuseppe Castagno (aka beppec56)
Modified: 2013-08-07 14:42 UTC (History)
7 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
file not displayed corectly as described. (10.00 KB, application/vnd.oasis.opendocument.text)
2007-09-17 22:43 UTC, Giuseppe Castagno (aka beppec56)
no flags Details
new version of doc with graphic embedded (14.06 KB, application/vnd.oasis.opendocument.text)
2007-09-17 22:51 UTC, Giuseppe Castagno (aka beppec56)
no flags Details
Writer document with draw object (11.85 KB, application/vnd.oasis.opendocument.text)
2008-01-03 15:52 UTC, stefan.baltzer
no flags Details
patch for Symbol shapes to be drawn in writer (711 bytes, patch)
2008-01-14 17:07 UTC, eric.bachard
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description Giuseppe Castagno (aka beppec56) 2007-09-17 22:42:41 UTC
The file I'm going to attach does not show correctly in m228, nor does in m229.

To reproduce:

- open the attached doc with 2.3.0, it's displayed correctly
- now open it with m228 (or m229) three shapes disappears.

Last correct was m226.
Comment 1 Giuseppe Castagno (aka beppec56) 2007-09-17 22:43:58 UTC
Created attachment 48288 [details]
file not displayed corectly as described.
Comment 2 Giuseppe Castagno (aka beppec56) 2007-09-17 22:51:00 UTC
Adjusted summary. 
I forgot to mention that the issue showed up on my builds. Lacking Hamburg
builds I have no way to check.

I'll attach a new version of the issue doc with embedded graphic, the first one
was linked.
Comment 3 Giuseppe Castagno (aka beppec56) 2007-09-17 22:51:59 UTC
Created attachment 48289 [details]
new version of doc with graphic embedded
Comment 4 michael.ruess 2007-09-18 10:49:10 UTC
MRU->OD: please try the second attachment. There are a graphic and three shapes
in it. In OO 2.2.1 the shapes are displayed, but not in OO 2.3 and m228 anymore.
I was not able to reproduce it with docuents built by myself. Could you please
have a look what's happening here? Thanks!
Comment 5 Giuseppe Castagno (aka beppec56) 2007-09-18 12:40:12 UTC
I did some other tests.

In m228 I tried to add some shapes, I was successful with some of them:

- rectangle: added and displayed
- ellipse: added and displayed
- basic shapes: when added nothing is displayed but the handles, the shape is
not shown, but if you save the doc and open it with 2.3.0 you can see them.
- star shapes: same as basic shapes.

I repeated the same test as above with a newly built m229 (9222), the behavior
was the same as for m228 described above.
Comment 6 groucho266 2007-09-24 13:21:11 UTC
Looks like the problem was introduced in CWS navorder.

I have not yet an explanation of how the changes in that CWS could result in not
painting custom shapes in the Writer (in Impress they are OK).
Comment 7 groucho266 2007-09-24 16:30:11 UTC
Setting target to 2.4 because I can not reproduce the issue on OOG m5. I can
reproduce it on SRC680 m228, so does not look like the bug was introduced into
the 2.3 code line.
Comment 8 michael.ruess 2007-10-08 11:08:26 UTC
*** Issue 82364 has been marked as a duplicate of this issue. ***
Comment 9 cno 2007-10-08 12:04:29 UTC
Hi *
Sorry I didn't find this issue before submitting mine. 

Remark: in OOo 2.2.1 and 2.3 it is no problem at all to insert a shape from the
Drawing toolbar in Writer.

This issue is a regression compared to 2.2.1 and 2.3 and IMO a serious bug. So
pls fix before releasing 2.3.1.
Comment 10 cno 2007-10-09 09:00:43 UTC
Just to make clear: my duplicatie issue #82364 was not (only) about the fact
that shapes are not displayed, but about the fact that it is impossible to
insert shapes.
Comment 11 groucho266 2007-10-31 15:06:28 UTC
The cause of this bug is an optimization made in
SdrObject::getSdrObjectFromXShape() and ::GetSdrObjectFromXShape(): the lines

 	SvxShape* pShape = SvxShape::getImplementation( xShape );

were replaced by

 	SvxShape* pShape = dynamic_cast< SvxShape* >( xShape.get() );

The later does not take the Writer implementation with its SwXShape class into
account and fails in that case.

Reverting this change fixes the bug.
Comment 12 michael.ruess 2007-11-16 10:27:16 UTC
*** Issue 83690 has been marked as a duplicate of this issue. ***
Comment 13 groucho266 2007-12-04 12:35:10 UTC
Please verify.
Comment 14 stefan.baltzer 2008-01-03 15:49:32 UTC
SBA: Put Sophie on CC.
I will attach a bugdoc that did not open at all (box: "Error reading file")
before this fix. Tried that one in CWS installation on Windows -> Opens fine.
Comment 15 stefan.baltzer 2008-01-03 15:52:45 UTC
Created attachment 50646 [details]
Writer document with draw object
Comment 16 michael.ruess 2008-01-04 09:10:51 UTC
*** Issue 84970 has been marked as a duplicate of this issue. ***
Comment 17 stefan.baltzer 2008-01-04 10:39:55 UTC
Note:
It looks like the document I attached belongs to issue 83248 ("Writer Document
with draw object containing connectors fails to load"). But that one already has
a previously unloadable attachment and got fixed in the same CWS. 
Comment 18 clippka 2008-01-14 15:58:50 UTC
*** Issue 84908 has been marked as a duplicate of this issue. ***
Comment 19 eric.bachard 2008-01-14 16:08:35 UTC
Hello,

Sorry for the dupe, but I never found the existing issue before to submit mine.

Can anybody tell me in wich cws the fix has been commited?
I'd like to test it with Aqua version, and if you need it, I propose to confirm it works

Thanks :)
Comment 20 eric.bachard 2008-01-14 16:09:12 UTC
+CC for me
Comment 21 eric.bachard 2008-01-14 17:07:06 UTC
Created attachment 50859 [details]
patch for Symbol shapes to be drawn in writer
Comment 22 eric.bachard 2008-01-14 17:08:56 UTC
Indeeed, the attached patch seems to fix the issue
Comment 23 eric.bachard 2008-01-14 17:39:00 UTC
impress132 is probably the right cws
Comment 24 christian.guenther 2008-01-16 17:47:15 UTC
CGU: Verified in cws Impress132
Comment 25 eric.bachard 2008-01-17 07:35:32 UTC
*** Issue 85313 has been marked as a duplicate of this issue. ***
Comment 26 eric.savary 2008-01-31 13:56:32 UTC
*** Issue 85758 has been marked as a duplicate of this issue. ***
Comment 27 christian.guenther 2008-02-07 11:46:46 UTC
CGU: Integrated in src680m245 and ooh680m5