Issue 82689 - editing a used list styles is not covered by the undo function
Summary: editing a used list styles is not covered by the undo function
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: OOo 2.3
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: eric.savary
QA Contact: issues@sw
URL:
Keywords:
Depends on:
Blocks: 72764
  Show dependency tree
 
Reported: 2007-10-17 08:17 UTC by norbert2
Modified: 2013-08-07 14:42 UTC (History)
5 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
issue_82689.odt (document to reproduce the bug) (6.54 KB, application/vnd.oasis.opendocument.text)
2007-10-17 08:19 UTC, norbert2 		no flags Details
patchfile (440 bytes, text/plain)
2007-11-20 02:21 UTC, liuyu 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description norbert2 2007-10-17 08:17:36 UTC 
Hi,

please ...

- open the attached odt

- open the "Styles and Formatting" window (if not already open)

- switch to "List Styles"

- right-click "Numbering 1" "Modify..."

- change anything here, for example apply a bullet:

The save button has been enabled as expected, but undo is disabled.
Comment 1 norbert2 2007-10-17 08:19:07 UTC 
Created attachment 48953 [details]
issue_82689.odt (document to reproduce the bug)
Comment 2 norbert2 2007-10-17 08:20:23 UTC 
(Found on SO8 PU8 Linux and OOo 2.3 Windows.)
Comment 3 michael.ruess 2007-10-17 14:44:57 UTC 
MRU->AMA: problem is, when a list style has already been applied somewhere in
the document. Then a change in that style won't be undoable anymore.
works fine if the style has not been used...
Comment 4 liuyu 2007-11-20 02:21:31 UTC 
Created attachment 49756 [details]
patchfile
Comment 5 liuyu 2007-11-20 02:26:49 UTC 
liuyu->ama: I find a way to solve this problem, but I'm not sure if it will 
bring other problems. Please have a look at the patch.
Comment 6 andreas.martens 2007-11-20 16:08:28 UTC 
ama->liuyu:
To be honest, I do not know if this change causes side effects. First I get an
violated assertion from the SwUndoInsNum object but I do not know at the moment
if this is really a problem.
I will talk to my colleagues and have a deeper look into the code.
Stay tuned!
Comment 7 andreas.martens 2007-11-21 10:24:45 UTC 
ama->liuyu:
Great! I thought we would need a new SwUndo class and a lot of coding but you
found the right place to fix this issue with a cool small patch!
The piece of code you changed has been checked in 10 years ago when Writer
wasn't able to undo any style changes.
I do not see any problems nor side effects of your patch, it will be integrated
into CWS sw8u10bf02.
Comment 8 andreas.martens 2007-11-21 10:25:57 UTC 
Fixed in CWS sw8u10bf02
docnum.cxx
unnum.cxx
Comment 9 andreas.martens 2007-12-04 09:34:03 UTC 
Ready for QA
Comment 10 eric.savary 2007-12-13 15:45:03 UTC 
Verified in CWS sw8u10bf02

Note: follow up issue 84546 because the string in the Undo menu is wrong.
Comment 11 thorsten.ziehm 2009-07-20 14:55:32 UTC 
This issue is closed automatically and wasn't rechecked in a current version of
OOo. The fixed issue should be integrated in OOo since more than half a year. If
you think this issue isn't fixed in a current version (OOo 3.1), please reopen
it and change the field 'Target Milestone' accordingly.

If you want to download a current version of OOo =>
http://download.openoffice.org/index.html
If you want to know more about the handling of fixed/verified issues =>
http://wiki.services.openoffice.org/wiki/Handle_fixed_verified_issues