Issue 83934 - binary-only blob in vcl
Summary: binary-only blob in vcl
Status: CLOSED FIXED
Alias: None
Product: gsl
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All All
: P2 Trivial (vote)
Target Milestone: OOo 2.4
Assignee: philipp.lohmann
QA Contact: issues@gsl
URL:
Keywords:
Depends on: 81093
Blocks: 84957
  Show dependency tree
 
Reported: 2007-11-24 19:30 UTC by rene
Modified: 2008-01-29 14:01 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description rene 2007-11-24 19:30:11 UTC
cws beppec56pdf1b adds a new header to vcl:

vcl 	inc/vcl/sRGB-IEC61966-2.1.hxx 	1.2 	beppec56 	i59651

which is bascially a binary-only blob and therefore a binary-only file (strictly
speaking) and therefore a P1 (as discussed in HH).

Issue 81093 talks about this and even has a clean solution which is blocked by
Sun approval...

This *has* to be fixed asap.
Comment 1 Martin Hollmichel 2007-11-27 09:47:06 UTC
approval done.
Comment 2 rene 2008-01-09 09:37:36 UTC
and why is this set to FIXED? Where is this fixed? This is still present in
OOH680_m1.

reopening. Please fix.
Comment 3 rene 2008-01-09 09:39:03 UTC
reassign to beppec56
Comment 4 philipp.lohmann 2008-01-09 09:46:32 UTC
As far as I remember this is going to be fixed by CWS beppec56pdffix02. However
how this is P1 I fail to see.
Comment 5 rene 2008-01-09 09:51:47 UTC
it's about non-free, binary-only things in the source and we agreed in Hamburg
that such bugs *are* P1
Comment 6 rene 2008-01-09 09:53:11 UTC
beppec56: please add this issue to your cws, too
Comment 7 philipp.lohmann 2008-01-09 17:51:50 UTC
How about a quick reality check ? We're talking about a data file in a well
defined format here (an ICC stream). The same way we provide icons, fonts and
lots of other binary files, only this one is encapsulated in a header since the
tool that would generate said header is not yet checked in.

"Nonfree" does not apply in any case, the header in question and obviously the
contained file are LGPL 2.1 (courteously provided by beppec56). The original ICC
profile is even less restrictive licensed, it can be distributed by anyone.

So what exactly about this issue is so outrageous, that it MUST PREVENT the next
build ?
Comment 8 rene 2008-01-09 18:12:19 UTC
> How about a quick reality check ? We're talking about a data file in a well
> defined format here (an ICC stream). The same way we provide icons, fonts and
> lots of other binary files, ...

and it's still software, so it' still has to be free software to be able to
be redistributed by Debian at all. And be it only in the source.

> only this one is encapsulated in a header since the
> tool that would generate said header is not yet checked in.

Which is to be fixed. Which this issue is about. 

> "Nonfree" does not apply in any case, the header in question and obviously the
> contained file are LGPL 2.1 (courteously provided by beppec56). ...

Eh... I can also take a RFC (which is forbidden to be edited), make a hex out of
it and put a LGPL blurb about it.

Still would violate the license, and you are not allowed to re-license it anyway
unless you are the copyright holder or the license of the original file
explicitely allows re-licensing.

> The original ICC rofile is even less restrictive licensed, it can be
> distributed by anyone.

Wow. Distributed. Read the Open Source definition, please. Distribution is only
*one* of the possibilities you need to have. You also need to have the right to
modify it and distribute modified versions, too.

See my comment "------- Additional comments from rene Tue Aug 28 14:17:33 +0000
2007 -------" at Issue 81093:
""provided that the files are not changed [...]" is in the license.

> So what exactly about this issue is so outrageous, that it MUST PREVENT the
> next build ?

That we have transformed non-free files into a blob and have put it into a
header used by vcl.

Comment 9 rene 2008-01-09 18:20:48 UTC
> So what exactly about this issue is so outrageous, that it MUST PREVENT the
> next build ?

What's so outrageous is that non-conditional stuff gets added relying on
non-free software. Of course, this can be fixed via beppecpdffix02.

beppec56: What is the status of this cws?

It is P1 because it was agreed on an ESC Meeting that it is. That your
definition of P1 means "stop the build" is not my problem, I just know this must
be fixed ASAP.
Comment 10 Giuseppe Castagno (aka beppec56) 2008-01-10 09:42:13 UTC
Accepted, added to cws beppec56pdffix02.

A few lines on the current cws status.
On CVS  the cws still misses the new 'icc' module, the one part that should go
to HEAD, since  when I started adding it I quickly realized I was going to mess
things up with the CVS data base. So I stopped, and asked for help. Help should
be on the way.

At my end the cws code builds under Linux and Windows, though under Windows it
needs the cygwin g++ compiler, not mentioned anywhere on the build requirement
documentation, but requested by the office configure process.
Anyway it seems that under Windows g++ it's now required because of guw.exe.

I still need help to build it under other platforms though.

The current ICC embedded as a 'binary blob' in the OOo code was already
generated by me using this library, so it has the LGL 2.1 license and the
contents it's generated, not edited, as can be seen analyzing a PDF/A-1a file
exported by OOo (both SRC680_m242 and OOH680_m1 contain the this code).

So, in the end, the 'blob' it's not an edited version, but a new one, recomputed
according to  IEC61966-2.1:1999 standard.
Comment 11 philipp.lohmann 2008-01-10 10:05:40 UTC
P1 on blocking the next build is not "my definition". Have actually ever read
the pririty meanings ? Hint:
http://www.openoffice.org/scdocs/ddIssues_EnterModify.html#priority

However you agreed that this can be fixed in a normal CWS fashion. That
automatically makes it a non P1 issue. Moreover it's a duplicate, which you
stated yourself even when filing it.
Comment 12 Giuseppe Castagno (aka beppec56) 2008-01-12 12:56:50 UTC
Set Fixed, and reassign to pl.
Please verify it in cws beppec56pdffix02
Comment 13 Giuseppe Castagno (aka beppec56) 2008-01-12 12:57:39 UTC
reassigning...
Comment 14 philipp.lohmann 2008-01-13 09:23:47 UTC
verified in CWS beppec56pdffix02
Comment 15 philipp.lohmann 2008-01-29 14:01:28 UTC
seen in OOH680m5, closing