Issue 85226 - SUBTOTAL result not updated when undoing autofilter
Summary: SUBTOTAL result not updated when undoing autofilter
Alias: None
Product: Calc
Classification: Application
Component: editing (show other issues)
Version: OOo 2.3.1
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: oc
QA Contact: issues@sc
Depends on:
Blocks: 72764
  Show dependency tree
Reported: 2008-01-14 11:46 UTC by daniel.rentz
Modified: 2013-08-07 15:14 UTC (History)
5 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

A patch to the issue 85226 (594 bytes, text/plain)
2008-07-24 04:07 UTC, gaozm
no flags Details
A new patch to issue 85226 (537 bytes, text/plain)
2008-08-01 08:24 UTC, gaozm
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description daniel.rentz 2008-01-14 11:46:58 UTC
- create a sheet containing a range with autofilter and a SUBTOTAL function to
the filtered range
- modify filter -> SUBTOTAL result will be updated to calculate with visible
cells only
- undo the filter -> SUBTOTAL result will NOT be updated
Comment 1 ooo 2008-01-14 12:04:27 UTC
Comment 2 gaozm 2008-07-24 04:07:41 UTC
Created attachment 55336 [details]
A patch to the issue 85226
Comment 3 ooo 2008-07-24 11:13:52 UTC
Even if the attached patch may fix the symptom, it does not fix the underlying
cause. What this patch does is it recalculates the formula cell unconditionally,
regardless whether it is flagged dirty or not. This is not desired. Furthermore,
ScFormulaCell::InterpretTail() should never be called on its own, but only from
the places within ScFormulaCell::Interpret() for which it was designed.

Btw, please include the diff -p option when generating patches, which for C/C++
shows the method a change is in.
Comment 4 gaozm 2008-08-01 08:24:23 UTC
Created attachment 55488 [details]
A new patch to issue 85226
Comment 5 niklas.nebel 2008-08-19 18:11:48 UTC
Yes, it looks like that is really all that's needed (same as in ScDBDocFunc::Query).
Comment 6 niklas.nebel 2008-10-27 18:04:58 UTC
taking the issue
Comment 7 niklas.nebel 2008-10-27 18:05:33 UTC
I added the last patch to CWS "calc47".
Comment 8 niklas.nebel 2008-12-04 15:43:11 UTC
Reassigning to QA for verification
Comment 9 oc 2008-12-09 13:53:46 UTC
verified in internal build cws_calc47
Comment 10 thorsten.ziehm 2009-07-20 14:52:00 UTC
This issue is closed automatically and wasn't rechecked in a current version of
OOo. The fixed issue should be integrated in OOo since more than half a year. If
you think this issue isn't fixed in a current version (OOo 3.1), please reopen
it and change the field 'Target Milestone' accordingly.

If you want to download a current version of OOo =>
If you want to know more about the handling of fixed/verified issues =>
Comment 11 thorsten.ziehm 2009-07-20 15:35:12 UTC
Sorry this issue was wrongly closed. This issue will be reopened automatically.
And will be set after that back to fixed/verified.
Comment 12 thorsten.ziehm 2009-07-20 15:39:46 UTC
Set to state 'fixed'.
Comment 13 thorsten.ziehm 2009-07-20 15:44:03 UTC
Set back to state 'verified/fixed'.

Again. Sorry for the mass of mails.
Comment 14 thorsten.ziehm 2010-02-22 14:48:56 UTC
This issue is closed automatically. It should be fixed in a version with is
available for longer than half a year (OOo 3.1). If you think this issue isn't
fixed in the current version (OOo 3.2) please reopen it. But then please pay
attention about the field 'target milestone'.
The closure was approved by the Release Status Meeting at 22nd of February 2010
and it is based on the issue handling guideline for fixed/verified issues  :