Issue 85480 - Crash reporting broken on all supported non Windows platforms
Summary: Crash reporting broken on all supported non Windows platforms
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: 680m236
Hardware: All All
: P1 (highest) Trivial (vote)
Target Milestone: OOo 2.4
Assignee: Joost Andrae
QA Contact: issues@framework
URL:
Keywords:
Depends on:
Blocks: 84957
  Show dependency tree
 
Reported: 2008-01-22 16:02 UTC by hennes.rohling
Modified: 2008-02-01 15:22 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Proposed patch. (2.11 KB, text/plain)
2008-01-22 18:37 UTC, Yuri Dario 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description hennes.rohling 2008-01-22 16:02:06 UTC 
CWS os202 introduced changes to at least the following files:

svx/source/dialog/docrecovery.cxx
svx/source/unodraw/recoveryui

where some ifdefs were changed from

#if defined(WNT)
to

#if defined(WNT) || !defined(OS2)

@ydario: I don't know what the intention of those changes was but now those
lines that where previously only compiled and executed on Windows are now
executed on every platform except OS/2. One result is that crash report
submission won't work anymore for Linux and Solaris.

This is an OOo 2.4 Showstopper.
Comment 1 hennes.rohling 2008-01-22 16:03:21 UTC 
Blocks showstopper meta task. Approved by UL.
Comment 2 hennes.rohling 2008-01-22 16:04:14 UTC 
Added CCs
Comment 3 Yuri Dario 2008-01-22 16:26:35 UTC 
I wrote this code in 2006, and it seems to be wrong because the idea was to get
windows behaviour also under OS/2.
Since crash recovery is not complete under os2, the above bug never showed here.

The right code is then

#if defined(WNT) || defined(OS2)

I can commit the fix to os2port03 cws (which is synched with ooh680 m2 now), but
this cws was probably too late for integration in 2.4.
Comment 4 Martin Hollmichel 2008-01-22 16:32:08 UTC 
this should be easy doable as masterfix, will you please coordinate with Heiner
to coordinates this ?
Comment 5 Yuri Dario 2008-01-22 17:04:54 UTC 
what is a masterfix?
who is heiner?
thanks.
Comment 6 jens-heiner.rechtien 2008-01-22 17:10:35 UTC 
@ydario: a master fix is a quick fix that is taken directly in to a major code
line by release engineering. It's an exception to the rule that everything
should be done on child workspaces. Heiner, well, that would be me, the release
engineer who will build the next milestone for OOo-2.4.
Comment 7 Yuri Dario 2008-01-22 17:46:32 UTC 
thanks Heiner, now I understand. What should I do now?
Is it possible to put also os2port03? :-)
Comment 8 jens-heiner.rechtien 2008-01-22 18:19:59 UTC 
@ydario: a patch attached to this issue would be nice, but I can figure it out
myself if necessary.
Comment 9 Yuri Dario 2008-01-22 18:37:04 UTC 
Created attachment 51081 [details]
Proposed patch.
Comment 10 hennes.rohling 2008-01-23 10:05:20 UTC 
The patch looks good. As far as I've seen using of ifdefs in other files
introduced by the CWS os2port02 was OK.

@hr: Please take care to include the patch in the OOH680 and the SRC680 master.
Comment 11 jens-heiner.rechtien 2008-01-24 17:55:17 UTC 
Fixed as masterfix in OOH680 m5.
Comment 12 hennes.rohling 2008-02-01 15:00:20 UTC 
Seen OK on SRC680 m254 too.

@ja: Please verify
Comment 13 Joost Andrae 2008-02-01 15:21:41 UTC 
verified for Linux and Solaris in OOH680_m5
and verified in SRC680_m245
Comment 14 Joost Andrae 2008-02-01 15:22:14 UTC 
closing issue