Issue 86367 - embeddedobj: remove unused methods
Summary: embeddedobj: remove unused methods
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: 680m247
Hardware: All Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 3.0
Assignee: mikhail.voytenko
QA Contact: issues@framework
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-22 19:22 UTC by caolanm
Modified: 2008-07-12 11:32 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
patch to remove unused code (17.86 KB, patch)
2008-02-22 19:23 UTC, caolanm
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2008-02-22 19:22:25 UTC
attached is a patch to remove (or ifdef WNT where relevant) unused methods in
embeddedobj
Comment 1 caolanm 2008-02-22 19:23:08 UTC
Created attachment 51666 [details]
patch to remove unused code
Comment 2 Mathias_Bauer 2008-02-22 21:30:47 UTC
Thanks for the patch.
I'm quite irritated that so much methods are unused here. Maybe some of them are
necessary though, Mikhail should know.
Comment 3 caolanm 2008-02-22 22:52:45 UTC
well it is a sort of dead end code path these days, and the vast majority is
good code, except windows only, so I'm not really bothered by the amount, you
should see the vast and incredible spewage from sc!
Comment 4 mikhail.voytenko 2008-02-28 07:58:39 UTC
Thank you for the patch, I will integrate it in one of the next cws.
Yes, the part of the functionality was removed, so some methods are dead.
Comment 5 mikhail.voytenko 2008-05-27 16:31:36 UTC
Integrated.
Comment 6 mikhail.voytenko 2008-05-30 08:12:23 UTC
This is a development issue.
Comment 7 caolanm 2008-07-12 11:32:03 UTC
seen in master