Issue 88075 - wrong percentage display in data label - approved
Summary: wrong percentage display in data label - approved
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: kla
QA Contact: issues@graphics
Keywords: regression
Depends on:
Blocks: 72764 88258
  Show dependency tree
Reported: 2008-04-09 06:44 UTC by rafaelda
Modified: 2013-02-24 21:22 UTC (History)
4 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

See the chart (22.37 KB, image/png)
2008-04-09 06:47 UTC, rafaelda
no flags Details
Sample spreadsheet with a chart (23.58 KB, application/vnd.oasis.opendocument.spreadsheet)
2008-04-09 06:49 UTC, rafaelda
no flags Details
Correct Percentage Mock Up (40.54 KB, image/png)
2008-04-10 08:14 UTC, rafaelda
no flags Details
patch_080411 (413 bytes, text/plain)
2008-04-11 08:38 UTC, weiz
no flags Details
patch_080415 (2.44 KB, text/plain)
2008-04-15 07:35 UTC, weiz
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description rafaelda 2008-04-09 06:44:57 UTC
I'm using BrOffice 2.4.
In my spreadsheet there is a chart that shows the percentage of each kind of
expenditure I have each month.
Up to BrOffice 2.3.1 it was showing correctly the percentage but now, in 2.4, it
shows the real value followed by the "%" symbol.
See the attached picture and the attached sample.
I don't know if I should open another issue for this: If I change the properties
of the chart bar to show the value (instead of showing the percentage) it shows
a enormous value that I don't know from where it came from.
Comment 1 rafaelda 2008-04-09 06:47:20 UTC
Created attachment 52669 [details]
See the chart
Comment 2 rafaelda 2008-04-09 06:49:09 UTC
Created attachment 52670 [details]
Sample spreadsheet with a chart
Comment 3 kla 2008-04-09 09:39:04 UTC
The Chart Type they are chosen is "percent stacked". Switch to stacked and all
will be fine.
Comment 4 rafaelda 2008-04-10 08:12:30 UTC
No it won't.
I think that by saying that I should change the type of chart you just admitted
that "Percent stack" have problems in 2.4 so I guess I can say that it doesn't
I'm reopening this issue because it doesn't works as it's expected and it's a
regression since it was working fine in 2.3 and in 2.3.1.
Unfortunately I deleted my copy of OOo 2.3.1 after I downloaded 2.4 so I won't
be able to do a screen capture of how it was working correctly in that version
but I will do a mock up.

See the new attached file.

In Janeiro's bar the blue part should show the vlaue "4,03%" because R$ 25,80 is
4,03% of all the expenditures of Janeiro (25,80+250+13+24+327,89). The red part
of Janeiro's bar should show the value "39,02%" because 250 is 39,02% of all the
expenditures fo that month. It worked this wsay in 2.3 and 2.3.1 and it should
work this way in 2.4.
Comment 5 rafaelda 2008-04-10 08:14:48 UTC
Created attachment 52706 [details]
Correct Percentage Mock Up
Comment 6 IngridvdM 2008-04-10 09:47:08 UTC
I can confirm the problem and take the issue.
Comment 7 IngridvdM 2008-04-10 09:48:36 UTC
Comment 8 IngridvdM 2008-04-10 10:47:42 UTC
->weiz: Please have a look at this problem. Thanks a lot!
Comment 9 weiz 2008-04-11 08:32:59 UTC
->iha: the patch is finished, I only delete two lines in the 
function "getLabelTextForValue", and I noticed that the function is related to 
issue 43489, hope my modification wouldn't effect that issue.
Comment 10 weiz 2008-04-11 08:38:42 UTC
Created attachment 52747 [details]
Comment 11 IngridvdM 2008-04-14 16:57:36 UTC
->weiz: Thanks a lot! As far as I tested it, the fix works! Only a bit code
hygiene should be done: As the parameter fSumValue is useless now please remove
it from the method. For me the current patch even does not compile on windows as
unused parameters produce a warning which are treated as error per default in
OOo. Thanks, Ingrid.
Comment 12 weiz 2008-04-15 07:35:24 UTC
Created attachment 52825 [details]
Comment 13 weiz 2008-04-15 07:36:42 UTC
->iha: The new patch is submitted. Thank you!
Comment 14 IngridvdM 2008-04-15 10:14:24 UTC
->weiz: Thanks a lot! The patch works fine. I checked it into CWS chart26.
I think this fix should be integrated into OOo 2.4.1 as it is a bad regresison.
So I changed the target accordingly.
Comment 15 IngridvdM 2008-04-24 10:29:08 UTC
->Thomas, please verify in CWS chart26. You will need to press F9 or
double-click on the chart in the example document thus a new image is generated
showing the correct label.
Comment 16 uwe.luebbers 2008-04-28 12:02:46 UTC
added "approved" to the title, because it will be easier to work with the 2.4.1 meta issue 
during release status meetings.
Comment 17 kla 2008-04-29 16:18:48 UTC
Seen ok in CWS chart 26 -> verified in CWS chart26
Current status will not switched to verified, after the issue is also verified
in CWS c03v13
Comment 18 kla 2008-05-06 09:39:37 UTC
Comment 19 kla 2008-09-02 15:45:43 UTC
Seen ok in current master -> closed