Issue 88286 - crash changing the iconset on Aqua version
Summary: crash changing the iconset on Aqua version
Status: CLOSED IRREPRODUCIBLE
Alias: None
Product: porting
Classification: Code
Component: MacOSX (show other issues)
Version: DEV300m3
Hardware: Mac Mac OS X, all
: P2 Trivial (vote)
Target Milestone: OOo 3.0
Assignee: carsten.driesner
QA Contact: issues@porting
URL:
Keywords:
: 88285 (view as issue list)
Depends on:
Blocks:
 
Reported: 2008-04-14 23:26 UTC by eric.bachard
Modified: 2008-05-27 07:59 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
a patch (as workaround) (742 bytes, patch)
2008-04-14 23:28 UTC, eric.bachard
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description eric.bachard 2008-04-14 23:26:27 UTC
Mac OS X Intel / 10.4.11  /  crash when changing the iconset

The log of the crash shown SvtMiscOptions_Impl::CallListeners() as potential candidate.
After tracing a bit, looks list, for some reason, aList is not defined, or the right member is missing, or, 
dont know exactly.

Testing if aList != NULL and I can no longer repeat the crash.  

@pl : can you please have a look ? ( I'll attach a patch )


The log of the crash (randomly repeatable) :

Command: soffice.bin
Path:    /Users/ericb/Desktop/Prague2008/OpenOffice.org.app/Contents/MacOS/soffice.bin
Parent:  WindowServer [58]

Version: 3.0.0 (???)

PID:    3911
Thread: 0

Exception:  EXC_BAD_ACCESS (0x0001)
Codes:      KERN_INVALID_ADDRESS (0x0001) at 0x573d0431

Thread 0 Crashed:
0   <<00000000>> 	0x573d0431 0 + 1463616561
1   libfwkmxi.dylib       	0x1644abd9 component_writeInfo + 364471
2   libsvtmxi.dylib       	0x01771c8d SvtMiscOptions_Impl::CallListeners() + 65
3   libsvtmxi.dylib       	0x01772480 SvtMiscOptions_Impl::ImplSetSymbolsStyle(bool, short, 
rtl::OUString const&) + 294
4   libsvtmxi.dylib       	0x0177259e SvtMiscOptions::SetSymbolsStyle(short) + 72
5   libcuimxi.dylib       	0x26c4edab CreateDialogFactory + 193467
6   libcuimxi.dylib       	0x26c7c74b CreateDialogFactory + 380251
7   libvclmxi.dylib       	0x02184547 Control::ImplCallEventListenersAndHandler(unsigned long, Link 
const&, void*) + 115
8   libvclmxi.dylib       	0x02175daf Button::Click() + 39
9   libvclmxi.dylib       	0x02172c52 Window::EndTracking(unsigned short) + 262
10  libvclmxi.dylib       	0x0216d560 ImplHandleMouseEvent(Window*, unsigned short, unsigned char, 
long, long, unsigned long, unsigned short, unsigned short) + 874
11  libvclmxi.dylib       	0x0216f57d ImplWindowFrameProc(Window*, SalFrame*, unsigned short, void 
const*) + 579
12  libvclmxi.dylib       	0x021e182c AquaSalFrame::~AquaSalFrame [in-charge deleting]() + 10494
13  libvclmxi.dylib       	0x021df6b5 AquaSalFrame::~AquaSalFrame [in-charge deleting]() + 1927
Comment 1 eric.bachard 2008-04-14 23:26:48 UTC
Add pl on CC
Comment 2 eric.bachard 2008-04-14 23:28:17 UTC
Created attachment 52824 [details]
a patch (as workaround)
Comment 3 ace_dent 2008-04-15 08:57:40 UTC
*** Issue 88285 has been marked as a duplicate of this issue. ***
Comment 4 ace_dent 2008-04-15 09:00:13 UTC
Related issue:  Issue 86098 - 'crash when switching icons' ?
Comment 5 philipp.lohmann 2008-04-15 09:13:54 UTC
should be a duplicate to issue 86098

*** This issue has been marked as a duplicate of 86098 ***
Comment 6 philipp.lohmann 2008-04-15 09:15:09 UTC
closing
Comment 7 eric.bachard 2008-04-18 08:18:08 UTC
@pl : the patch from issue 86098 fixed nothing for me, but the one I used ( probably uggly) did.

What do ?
Comment 8 eric.bachard 2008-04-18 08:19:14 UTC
I forgot: I tested the patch from issue 86098 with DEV300_m8
Comment 9 philipp.lohmann 2008-04-21 12:13:26 UTC
reopen
Comment 10 philipp.lohmann 2008-04-21 12:20:15 UTC
if this patch fixes the crash and the one in issu 88098 doesn't this would seem
to indicate that CallListeners is called on a dead instance of
SvtMiscOptions_Impl. I don't see how that could happen, but this is not really
my code. The only thing noticeable is that SvtMiscOptions_Impl seems to have a
quaint self implemented refcounting system.
Comment 11 carsten.driesner 2008-05-07 07:38:05 UTC
cd: Accepted and must be fixed for OOo 3.0.
Comment 12 carsten.driesner 2008-05-19 08:44:11 UTC
cd: Crash must be P2.
Comment 13 carsten.driesner 2008-05-26 16:23:02 UTC
cd->pl,ericb: I couldn't reproduce a crash using a DEV300m14. Could you please confirm it? The patch looks strange 
as you try to check a normal member object, not a object pointer. I don't know why that fixed the crash. As Philipp 
already stated the root cause is based on the fact that SvtMiscOptions_Impl gets destroyed although some other 
code has a reference. That should never happen! Currently I am lost as I cannot reproduce the crash. 
Comment 14 eric.bachard 2008-05-26 17:59:10 UTC
@cd

I'll trust you :)  My patch was just a try, and since you can no longer reproduce, there is no problem for 
me to close the issue as invalid or wontfix



Comment 15 carsten.driesner 2008-05-27 07:58:40 UTC
cd: Closing issue as WORKSFORME.
Comment 16 carsten.driesner 2008-05-27 07:59:04 UTC
cd: Closed.