jrahemipour -> OC: As discussed recently, it is a hinderance when using the new
feature. Via dialog, undo is possible and this is what the user must expect when
toying manually with page margins. This should be fixed before OOo 3.0 to
"complete" this new feature (sba agrees after I showed him this on OOo QA meeting).
Put sba and pj on c/c. 

Hi Niklas, any change for OOo3.0?

In page preview mode, Undo is disabled because some of the existing actions
don't work there. I don't think we'll fix that for 3.0. An Undo action could be
added that can be seen only after leaving preview, similar to what happens when
the page format dialog is shown in page preview.

Hello Niklas,
If the Undo can be added in Margins. Then in page preview mode, the Undo will 
work all the time. Do you think of my idea right? I have a look at MS-
Excel,when the page is in page preview mode, the Undo can't work.

In page preview mode, some of the older undo implementations don't work. That's
why undo is completely disabled there.

My opinion is the Undo can't be added in page preview mode. If the Undo is 
usable,then we must take those operations in the page format dialog into 
account.
Hi Niklas,I want to know the meaning of this sentence(some of the older undo 
implementations).

IMO undo must be possible for *all* actions which are done in a document, but I
do not see the need, why undo must be possible in page preview mode.

I would suggest this behaviour: If page margins and columns are adjusted in page
preview, page preview can be closed and these multiple actions can be undone in
one step.

accept

started

Created attachment 54594 [details]
The patch file is about i88467#-v1

Hi Niklas,
The patch have a bit small problem,it can't rightly undo for page margins.
It can work for PageHeader and PageFooter.I hope you can give me some advice 
about margin's problems. Thanks!

How do you create your patches? Without changes, this doesn't compile because of
a missing brace. You should directly use diff output from working code.

The undo problem is actually caused by an error in the code from issue 51656:
You must never directly modify an item that is in an ItemSet (pLRItem in this
case). Instead, make a copy of the item, modify the copy and use it in
rStyleSet.Put.

Created attachment 54733 [details]
The patch is about i88467#-v2

One small thing: ScDocFunc::SetWidthOrHeight already sets the column width, so
the ScDocument::SetColWidth call is no longer needed.

Otherwise, this seems to work, and can be integrated when we have the branch for
3.1 and a CWS on that.

Created attachment 54738 [details]
The patch is about i88467#-v3

taking the issue

I added the last patch to CWS "calc47".

Reassigning to QA for verification

verified in internal build cws_calc47

As to 88467 has not been fixed in master version OOo-dev 3.1 .0 (OOO310m8 
Build:9395) for Windows XP. "Page preview, adjust margins -> undo" - has not 
been realized; "If page margins and columns are adjusted in page
preview, page preview can be closed and these multiple actions can be undone in
one step" - has not been realized.

vladimir_hitekschool,
Verified in OOo310m9 on WinXP and Fedora9, it works well.
when the page is in page preview mode, Undo doesn't work. If close preview,
check Undo down-arrow list, it works well.
Now closing this issue
Regards
Li Meiying