Issue 88652 - configure should not require unicows.dll on dev300 code line
Summary: configure should not require unicows.dll on dev300 code line
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: configure (show other issues)
Version: DEV300m10
Hardware: All All
: P3 Trivial (vote)
Target Milestone: 3.4.1
Assignee: Oliver-Rainer Wittmann
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-23 15:45 UTC by Mathias_Bauer
Modified: 2017-05-20 10:31 UTC (History)
6 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
presumably this is as trivial as this.... (2.80 KB, patch)
2009-10-20 11:44 UTC, caolanm 		no flags Details | Diff
patch to remove Window Build requirement of unicows.dll - it includes cmc's patch (20.28 KB, patch)
2011-09-27 14:33 UTC, Oliver-Rainer Wittmann 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Mathias_Bauer 2008-04-23 15:45:13 UTC 
unicows.dll is not needed anymore because we dropped win9x support
Comment 1 Mathias_Bauer 2008-04-23 15:45:41 UTC 
target 3.0
Comment 2 caolanm 2009-10-20 11:44:15 UTC 
Created attachment 65472 [details]
presumably this is as trivial as this....
Comment 3 Mathias_Bauer 2009-11-11 14:32:48 UTC 
I'll take over
Comment 4 Mathias_Bauer 2010-05-12 17:19:55 UTC 
According to OpenGrok there are some more places that refer to unicows:

postprocess/signing/no_signing.txt
postprocess/rebase/no_rebase.txt 
solenv/inc/set_wntx64.mk
solenv/inc/set_wntgcci.mk
solenv/inc/set_wntmsci10.mk
solenv/inc/set_wntmsci11.mk
ure/source/README
All are trivial fixes

sal/systools/win32/uwinapi/makefile.mk
sal/systools/win32/uwinapi/unicowsdxp
sal/systools/win32/uwinapi/unicows_mingw.dxp
I'm unsure about that; this is just a list of exported symbols. Perhaps someone
of the experts can comment on that.

sal/systools/win32/uwinapi/DllMain.cpp
The code to load unicows.dll should be removed also

sal/osl/w32/process.cxx
vcl/win/source/window/salframe.cxxMentions some workarounds for bugs in
unicows.dll; they should be removed then

vcl/win/source/app/salinfo.cxx
code for WINVER<0x5000 -> remove
Comment 5 Oliver-Rainer Wittmann 2011-09-22 09:35:57 UTC 
taking over in order to apply Caolan's patch and to clean up the rest of the code regarding unicows.dll
Comment 6 Oliver-Rainer Wittmann 2011-09-27 14:30:19 UTC 
taking over this issue
Comment 7 Oliver-Rainer Wittmann 2011-09-27 14:33:24 UTC 
Created attachment 76838 [details]
patch to remove Window Build requirement of unicows.dll - it includes cmc's patch
Comment 8 Oliver-Rainer Wittmann 2011-09-27 14:35:59 UTC 
I have attached a patch which includes cmc's patch and cleans up the references to unicows.dll given by mba.

Beside sal/systools/win32/uwinapi/DllMain.cpp the patch also removes sal/systools/win32/uwinapi/DllGetVersion.cpp