Issue 90071 - display of charts with clipped data crashes office
Summary: display of charts with clipped data crashes office
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P2 Trivial (vote)
Target Milestone: ---
Assignee: kla
QA Contact: issues@graphics
Keywords: regression
: 88894 90943 (view as issue list)
Depends on:
Blocks: 88258 94185
  Show dependency tree
Reported: 2008-05-28 12:56 UTC by Frank Schönheit
Modified: 2013-02-24 21:20 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

document to reproduce the bug case (203.87 KB, application/vnd.oasis.opendocument.spreadsheet)
2008-05-28 12:57 UTC, Frank Schönheit
no flags Details
Fix for this issue in module chart2 (332 bytes, patch)
2008-05-28 15:40 UTC, bjoern.milcke
no flags Details | Diff
safe patch (1.01 KB, text/plain)
2008-06-03 13:50 UTC, IngridvdM
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description Frank Schönheit 2008-05-28 12:56:44 UTC
- open the attached spreadsheet document
- press Backspace in an empty cell, to mark the document modified
- save the document (Ctrl+S)
- press Backspace in an empty cell, to mark the document modified
- save the document (Ctrl+S)
=> OOo crashs (no crash reporter)

Actually, this only one of multiple ways how I managed to crash OOo with this
document. Nearly every attempt to save the document crashes, which makes editing
it up to impossible - all changes done are lost in the next save attempt.

Another possibility to crash, with the same document:
- open the document
- right-click onto the "Ø 2007" sheet
- choose "Delete Sheet" from the sheet's context menu
=> note the sheet "W" becomes current
- left-click onto the "Ø 2008" sheet to activate it
=> the sheet is not painted. Actually, it seems painting completely stopped
   in the document, as you can see when you minimize and restore the document
- with the mouse, click the "Open File" button in the main toolbar
=> crash
Comment 1 Frank Schönheit 2008-05-28 12:57:30 UTC
Created attachment 54021 [details]
document to reproduce the bug case
Comment 2 Frank Schönheit 2008-05-28 12:59:02 UTC
The problem is a regression between 2.3.1 and 2.4 => keyword "regression", P2,
target OOo 3.0.

Note I am going to nominate this as blocker for 2.4.1. The bug makes working
with this particular document, and perhaps with a whole class of documents,
effectively impossible.
Comment 3 niklas.nebel 2008-05-28 14:15:25 UTC
It's a Chart problem (Clipping::clipPolygonAtRectangle, lcl_addPointToPoly).
That code was changed for issue 66963.
Comment 4 bjoern.milcke 2008-05-28 15:40:31 UTC
Created attachment 54030 [details]
Fix for this issue in module chart2
Comment 5 bjoern.milcke 2008-05-28 15:45:13 UTC
Attached a fix for this issue. The fix is straight-forward. It was obviously a
memory allocation problem.

With the fix, the crash no longer appears. However I haven't checked thoroughly
that the document is correct. On first sight it is. As the fix is in the
view-code it does not affect the chart model, i.e. load and save should not be

->FST: Please check how to proceed. If this becomes a 2.4.1 issue this issue
should get an according target or a duplicated one with this target. Maybe it
makes sense to add this issue to an existing 2.4.1 CWS in that case, what do you
Comment 6 bjoern.milcke 2008-05-28 16:00:10 UTC
This came in with CWS chart15 (chart15_OOH680) in the fix for Issue 66963.
Comment 7 frank 2008-05-29 08:57:41 UTC
added MH to CC
Comment 8 IngridvdM 2008-06-03 13:49:36 UTC
I checked the patch from Björn and suggest a small change to be sure that the
added integers are properly initialized with zero. I'll attach the corrected patch.
Comment 9 IngridvdM 2008-06-03 13:50:36 UTC
Created attachment 54209 [details]
safe patch
Comment 10 IngridvdM 2008-06-03 14:05:15 UTC
I checked issue 66963 with the fix and it is ok, so no reopening to fear there.

This problem can in principle occur for line-charts, area-charts, xy-charts and
net charts when not all data points are shown. As an access to an uninitialized
variable is involved the symptoms of the problem can be different. I have seen
crashes and not properly repainting charts also.

I would estimate that this problem does occur often.
I further would estimate that the fix is safe enough to take it for OOo 2.4.1
even now.
Comment 11 IngridvdM 2008-06-03 14:09:42 UTC
Fixed in CWS chart27 for OOo 3.0.
Comment 12 IngridvdM 2008-06-03 14:12:17 UTC
*** Issue 88894 has been marked as a duplicate of this issue. ***
Comment 13 IngridvdM 2008-06-03 14:19:16 UTC
I changed the summary to be more informative, because the problem has nothing to
do with saving but instead with the display of charts with clipped data.
Comment 14 IngridvdM 2008-06-03 22:34:42 UTC
Also fixed in CWS chart28 for OOo 2.4.1
Setting target to 2.4.1 to fulfill CWS handling requirements thus the CWS can be
Comment 15 IngridvdM 2008-06-03 22:36:24 UTC
@Thomas, please verify in CWS chart28.
Comment 16 kla 2008-06-06 10:19:11 UTC
verified. Works fine with the attached doc and also with the documents attached
at 66963 and 88894. 
Comment 17 IngridvdM 2008-06-20 13:55:44 UTC
The fix for this issue was integrated to dev300m20 via chart28_DEV300 clone. So
i can remove the issue from CWS chart27.
Comment 18 IngridvdM 2008-06-23 09:39:26 UTC
*** Issue 90943 has been marked as a duplicate of this issue. ***
Comment 19 IngridvdM 2008-07-11 09:43:17 UTC
The integration of this fix to OOo 2.4.1. was refused. So I change the target to
The fix was instead integrated into the 3.0 code line starting with DEV300m20.
For other reasons I cannot recommend version DEV300m20 for use with charts, so
please use dev300m23 or newer.
Comment 20 kla 2008-08-27 14:13:47 UTC
Seen ok in current master -> closed