Apache OpenOffice (AOO) Bugzilla – Issue 90178
"File already exists" warning dialog is empty
Last modified: 2008-08-04 14:44:28 UTC
Having OOo-Dialogs not activated, the warning "File already exists" (to prevent overwriting an existing file by saving to the same name) does not show up. The dialog is empty. See screenshot.
Created attachment 54100 [details] Screenshot. Warning is empty. Should show: "File already exists. Do you want to overwrite?"
can confirm
TM->MAV: please have a look, thanks !
Since we seem to have difficulties to reproduce this, on what platform does this actually happen ? Without a method of reproduction there can be no fix. By "Having OOo-Dialogs not activated", you mean that in "Tools->Options->General->Open/Save Dialogs" the checkbox is unchecked ?
depending on what dialog that actually is that might be a problem in vcl (if it's one actually an OOo dialog) or in the native file picker (in which case cmc might have a hint for this). Adding him to CC.
The code in question is... dlg = gtk_message_dialog_new( NULL, GTK_DIALOG_MODAL, GTK_MESSAGE_QUESTION, GTK_BUTTONS_YES_NO, OUStringToOString( aResProvider.getResString( FILE_PICKER_OVERWRITE ), RTL_TEXTENCODING_UTF8 ).getStr() ); where FILE_PICKER_OVERWRITE is STR_SVT_ALREADYEXISTOVERWRITE and it works fine for me in English, and I haven't heard anything else on other languages, so.... a) if you use the "built-in" dialogs does the string work ? i.e. say "Die Datei existiert bereits. Soll sie überschrieben werden?" b) what's the output of locale, just to check what exactly it is
Ubuntu Linux 7.10 (Gnome) When "Tools->Options->General->Open/Save Dialogs" is checked, everything is fine. When "Tools->Options->General->Open/Save Dialogs" checkbox is unchecked, the dialog is empty, as shown in the screenshot. locale LANG=de_DE.UTF-8
ok, I see what's going on here. originally in tools/inc/tools/resmgr.hxx #define CREATEVERSIONRESMGR_NAME( Name ) #Name MAKE_NUMSTR( SUPD ) #define CREATEVERSIONRESMGR( Name ) ResMgr::CreateResMgr( CREATEVERSIONRESMGR_NAME( Name ) ) in the DEV300 series has changed to .... #define CREATEVERSIONRESMGR_NAME( Name ) #Name #define CREATEVERSIONRESMGR( Name ) ResMgr::CreateResMgr( #Name ) and in resourceprovider.cxx we have #define RES_NAME fps_office ... m_ResMgr = CREATEVERSIONRESMGR( RES_NAME ); e.g. take the following test and use gcc -E on it #define FOO svt #define CREATEVERSIONRESMGR_NAME( Name ) #Name #define CREATEVERSIONRESMGR( Name ) ResMgr::CreateResMgr( #Name ) CREATEVERSIONRESMGR( FOO ) #undef CREATEVERSIONRESMGR_NAME #undef CREATEVERSIONRESMGR #define CREATEVERSIONRESMGR_NAME( Name ) #Name #define CREATEVERSIONRESMGR( Name ) ResMgr::CreateResMgr( CREATEVERSIONRESMGR_NAME( Name ) ) CREATEVERSIONRESMGR( FOO ) the outcome is that what used to be ResMgr::CreateResMgr( "svt" ) now becomes ResMgr::CreateResMgr( "FOO" ) I suggest that the safest fix is probably to change tools from #define CREATEVERSIONRESMGR( Name ) ResMgr::CreateResMgr( #Name ) back to #define CREATEVERSIONRESMGR( Name ) ResMgr::CreateResMgr( CREATEVERSIONRESMGR_NAME( Name ) ) so as to get the same expansion rules, otherwise I can certainly change the gnome usage for this one case.
change occurred in supdremove02 cmc->rt: what should we do, change resmgr.hxx in case there are more uses of the pattern like this ? Or just fix the gnome fpicker one ?
I'd prefer changing tools' resmgr.hxx
I'm happy to take this fix into cmcfixes46
done in cmcfixes46
reassign for qa
Verified in CWS cmcfixes46
*** Issue 91313 has been marked as a duplicate of this issue. ***
*** Issue 91855 has been marked as a duplicate of this issue. ***
same as b6724906, fixed in CWS vcl91, same fix. Will probably result in a merge conflict.
They won't conflict, so its ok. pl's change expands the uses in fpicker of the CREATEVERSIONRESMGR macro to working ResMgr::CreateResMgr calls. My one changed the macro in tools so that macro expansion of CREATEVERSIONRESMGR works the way it used to do again.
verified in DEV300_m28 -> closed
*** Issue 92051 has been marked as a duplicate of this issue. ***