Issue 90969 - Crashed when insert a slide under outline view
Summary: Crashed when insert a slide under outline view
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: code (show other issues)
Version: OOo 2.4.0
Hardware: All All
: P2 Trivial (vote)
Target Milestone: OOo 3.0
Assignee: wolframgarten
QA Contact: issues@graphics
URL:
Keywords:
: 91527 (view as issue list)
Depends on:
Blocks:
 
Reported: 2008-06-23 02:58 UTC by liujianli
Modified: 2008-07-11 08:50 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description liujianli 2008-06-23 02:58:01 UTC 
1. Start a presentation.
2. Switch to Outline view,type Enter to create a slide.
3. Push the Undo button and then insert a new slide.

The presentation crashed.
Comment 1 wolframgarten 2008-06-23 07:54:17 UTC 
Reproducible. Reassigned.
Comment 2 groucho266 2008-06-23 09:14:30 UTC 
I can reproduce this crash when in step 3 I use the context menu of the slide
sorter to insert the new slide.
Comment 3 liujianli 2008-06-23 09:19:49 UTC 
Yes,you are right.That will make it crash too.
Comment 4 groucho266 2008-06-30 16:25:53 UTC 
The crash is caused by the undo managers of the document and the outline view
not being synchronized.  When a new slide is inserted via the slide sorter then
the redo actions of the undo manager of the document are deleted but not those
of the undo manager of the outline view.

Fixed by telling the sd::UndoManager of the document about the undo manager of
the outline view and have the former call ClearRedo() at the later whenever a
new undo action is added.  Only in the case that eventually leads to the crash
there seem to be any remaining redo actions that need to be deleted.

Modified files:
sd/inc/undo/undomanager.hxx    rev. 1.4.56.1
sd/source/core/undo/undomanager.cxx    rev. 1.5.56.1
Comment 5 groucho266 2008-07-03 09:05:44 UTC 
Forgot to check in the part in the OutlineView where the two undo managers are
actually linked.

Modified file is
/sd/source/ui/view/outlview.cxx    rev. 1.50.18.1
Comment 6 sven.jacobi 2008-07-03 11:56:49 UTC 
this issue is ready to be verified
Comment 7 wolframgarten 2008-07-03 15:13:06 UTC 
Verified in CWS.
Comment 8 groucho266 2008-07-10 10:07:20 UTC 
*** Issue 91527 has been marked as a duplicate of this issue. ***
Comment 9 wolframgarten 2008-07-11 08:50:01 UTC 
Tested in master DEV300_m24. Closed.