Issue 93607 - Hybrid PDF-import is broken
Summary: Hybrid PDF-import is broken
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: OOO300m5
Hardware: All All
: P1 (highest) Trivial (vote)
Target Milestone: OOo 3.0
Assignee: h.ilter
QA Contact: issues@framework
URL:
Keywords:
: 93826 (view as issue list)
Depends on:
Blocks: 88888
  Show dependency tree
 
Reported: 2008-09-08 13:38 UTC by h.ilter
Modified: 2009-07-20 15:59 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description h.ilter 2008-09-08 13:38:38 UTC 
- New Document
- Export it as hybrid PDF document
- Open the exported hybrid PDF with Office
-> I/O Error
Comment 1 clippka 2008-09-09 10:06:55 UTC 
taking over
Comment 2 clippka 2008-09-09 10:09:47 UTC 
started
Comment 3 clippka 2008-09-09 10:44:42 UTC 
current findings:

PDFDetector::detect correctly detects a hybrid pdf and adds "EmbeddedSubstream"
to the filter data.

Then in PDFIHybridAdaptor::filter, this filter data entry is gone
Comment 4 clippka 2008-09-09 11:32:12 UTC 
I compared the same pdf import extension in OOO300 m3 (where it works) and
OOO300 m5 (where it fails).

The difference is that PDFIHybridAdaptor::filter does not get the "Stream"
property from the media descriptor. It turns out that the "EmbeddedSubstream" is
always missing, even in the version that works.

So the ultimate question is, where is "Stream" gone?
Comment 5 clippka 2008-09-09 12:01:28 UTC 
The 'Stream' property was removed on purpose from the Media Descriptor in OOO300
m4 to fix another bug. I learned that using 'Stream' was a bad thing and should
not have been used at all.

I replaced this by using 'InputStream' which should be available in all cases
where 'Stream' was available in the past. This indeed fixes the issue.

This fix is only in the extension, so only the extension needs to be updated.
The updated extension will also work in version prior to OOO300 m4.

fixed in
sdext/source/pdfimport/pdfiadaptor.cxx (r.1.2.2.2.4.1)

also updated the version from '0.3' to '0.3.2' in
sdext/source/pdfimport/config/description.xml (r.1.2.2.2.4.1)
Comment 6 clippka 2008-09-09 12:13:09 UTC 
verified in cws build, back to qa
Comment 7 h.ilter 2008-09-09 14:02:19 UTC 
Verified with cws impress157 = ok
Comment 8 h.ilter 2008-09-15 08:31:42 UTC 
*** Issue 93826 has been marked as a duplicate of this issue. ***
Comment 9 thorsten.ziehm 2009-07-20 15:59:04 UTC 
This issue is closed automatically and wasn't rechecked in a current version of
OOo. The fixed issue should be integrated in OOo since more than half a year. If
you think this issue isn't fixed in a current version (OOo 3.1), please reopen
it and change the field 'Target Milestone' accordingly.

If you want to download a current version of OOo =>
http://download.openoffice.org/index.html
If you want to know more about the handling of fixed/verified issues =>
http://wiki.services.openoffice.org/wiki/Handle_fixed_verified_issues