Issue 95051 - Asian strings truncated in scale tabpage
Summary: Asian strings truncated in scale tabpage
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: stefan.baltzer
QA Contact: issues@graphics
URL:
Keywords: CJK
Depends on:
Blocks: 72764
  Show dependency tree
 
Reported: 2008-10-17 07:56 UTC by yuko
Modified: 2013-02-24 21:18 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Japanese X Axis and Y axis dialogs (39.32 KB, image/gif)
2008-10-17 07:57 UTC, yuko 		no flags Details
Chinese Y axis dialog (21.97 KB, image/gif)
2008-10-22 08:37 UTC, weiz 		no flags Details
patch_081031 (9.13 KB, patch)
2008-10-31 07:38 UTC, weiz 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description yuko 2008-10-17 07:56:11 UTC 
1. Chosse Format > Axis >  X Axis | Y Axis | X Axis |  Secondary X Axis |
Secondary Y Axis
2. Click Scale tab in the dialog

Japanese messages for "Automatic" are truncated.

ex.
       自動(      <==  mnemonic "A)" is missing
Comment 1 yuko 2008-10-17 07:57:40 UTC 
Created attachment 57197 [details]
Japanese X Axis and Y axis dialogs
Comment 2 stefan.baltzer 2008-10-20 12:32:34 UTC 
SBA: Confirmed.
SBA->IHA: As seen, same in Chinese UI. Western strings have enough room in this
dialog. Please proceed.
Comment 3 IngridvdM 2008-10-21 09:37:10 UTC 
@weiz, please have a look at this one.
The size of the check box is set to the calculated minimum size:
aCbxAutoMin.SetSizePixel( aCbxAutoMin.CalcMinimumSize() );
(in tp_Scale.cxx).
So the string size calculation seems to be wrong for Asian languages.
Maybe hdu can give a hint?
There is a similar issue 89430, where the calculated size is wrong also. Maybe
they are duplicate.
Comment 4 weiz 2008-10-22 08:37:18 UTC 
Created attachment 57372 [details]
Chinese Y axis dialog
Comment 5 weiz 2008-10-22 08:41:08 UTC 
@iha: I cannot confirm this issue in Chinese version.( Dev300m19 )
For testing, I increased the text, but the result is OK. ( as you can see at 
the attached image ).

And I found that there is no mnemonic (~A) at the Japanese and Chinese 
localization "Automatic"( chart2\source\controller\dialogs\localize.sdf ).
 
@yuko: I wonder why the mnemonic is shown at your dialog? Did you do something 
special? Thank you very much.
Comment 6 yuko 2008-10-22 10:06:21 UTC 
I verified that menmonic keys were not included in Japanese translations in the
file, 
but I did not do anything special.
Comment 7 IngridvdM 2008-10-28 10:12:27 UTC 
The mnemonics are created automatically when they are not given in the original
string. It seems that the length for the control is calculated at a time where
this automatic mnemonic is still missing.
So the solution of this problem must change the order of things happening. First
the automatic mnemonic must be added and then the size for the control can be
calculated correctly. See also HDUs comment in issue 89430.
Maybe methods PageCreated or ActivatePage are better places to calculate the
text size than the constructor of the tab page.
Comment 8 weiz 2008-10-31 07:38:38 UTC 
Created attachment 57605 [details]
patch_081031
Comment 9 weiz 2008-10-31 07:39:28 UTC 
@iha: The patch is submitted, please let me know your suggestions. Thank you!
Comment 10 IngridvdM 2009-01-09 16:15:51 UTC 
@weiz, your fix works fine. Thanks! I commited it to CWS chart35. A bit adaption
was necessary as the controls on the scale tabpage changed with DEV300m38.
Comment 11 IngridvdM 2009-01-19 14:07:53 UTC 
@Kla, please verify in CWS chart35. Thanks!
Comment 12 IngridvdM 2009-01-19 14:10:51 UTC 
@Kla, please verify in CWS chart35. Thanks! Use the zh-TW install set.
Comment 13 kla 2009-02-06 09:56:50 UTC 
Thx SBA for take over this issue.
Comment 14 stefan.baltzer 2009-02-06 11:30:01 UTC 
Verified in CWS chart35.
Comment 15 ivo.hinkelmann 2009-03-04 14:25:31 UTC 
*** Issue 99455 has been marked as a duplicate of this issue. ***
Comment 16 stefan.baltzer 2009-04-16 15:33:37 UTC 
OK in OOO310_m9. Closed.