Issue 95316 - desktop: Desktop::SystemSettingsChanging doesn't ever do anything
Summary: desktop: Desktop::SystemSettingsChanging doesn't ever do anything
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: DEV300m33
Hardware: All Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 3.1
Assignee: carsten.driesner
QA Contact: issues@framework
URL:
Keywords:
Depends on:
Blocks: 95318
  Show dependency tree
 
Reported: 2008-10-22 14:21 UTC by caolanm
Modified: 2009-02-04 16:31 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
simple patch (656 bytes, patch)
2008-10-22 14:22 UTC, caolanm 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2008-10-22 14:21:53 UTC 
In desktop/source/app/app.cxx

Desktop::SystemSettingsChanging has a

if ( !SvtTabAppearanceCfg::IsInitialized () )
    return;

at the top. As far as I can see SvtTabAppearanceCfg::IsInitialized is false for
the lifetime of OOo, so the method doesn't actually ever do anything.

I think this method is used to override vcl auto-detected system settings for
stuff like user-option selected drag and drop behaviour and so on. (Well, that's
what I want to use it for anyway)

So, either the method should do something, or go away. I guess there's probably
some history about this that I'm unaware of, but here's the naive patch to
renable it which seems to work fine for me
Comment 1 caolanm 2008-10-22 14:22:36 UTC 
Created attachment 57381 [details]
simple patch
Comment 2 Mathias_Bauer 2008-11-05 11:06:27 UTC 
Carsten, please have a look.
Comment 3 carsten.driesner 2008-11-18 14:48:33 UTC 
cd->cmc: Thanks for the patch. Indeed the implementation looks very strange to
me. Unfortunately I am not able to verify why the initial inventor of the code
committed comment out code. From my point of view the best solution is to commit
your patch and check carefully for possible side-effects.
Comment 4 carsten.driesner 2008-11-18 15:08:16 UTC 
cd: Fixed. Committed to CWS fwk95.
Comment 5 carsten.driesner 2008-12-15 09:02:48 UTC 
cd: Verified.
Comment 6 caolanm 2009-02-04 16:31:40 UTC 
closed, seen in DEV300_m40