Issue 96700 - (regression) Insert - File does not respect encoding of HTML file
Summary: (regression) Insert - File does not respect encoding of HTML file
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: open-import (show other issues)
Version: OOo 3.0
Hardware: All Windows, all
: P3 Trivial (vote)
Target Milestone: ---
Assignee: michael.ruess
QA Contact: issues@sw
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2008-11-28 21:56 UTC by kpalagin
Modified: 2013-08-07 14:44 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
file to repro the problem. (126 bytes, text/html)
2008-11-28 21:58 UTC, kpalagin 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description kpalagin 2008-11-28 21:56:35 UTC 
Repro:
1. Save attached .htm somewhere locally, start Writer.
2. Insert-File, navigate to .htm, Insert - you get junk.
3. File-Open opens the file just fine - Russian is readable.
Comment 1 kpalagin 2008-11-28 21:58:01 UTC 
Created attachment 58376 [details]
file to repro the problem.
Comment 2 kpalagin 2008-11-28 21:59:53 UTC 
This is regression - version 2.4.0 inserted the file with correct encoding.
Comment 3 eric.savary 2008-11-30 11:15:32 UTC 
@MBA: please have a look
Comment 4 Mathias_Bauer 2008-11-30 14:30:26 UTC 
Oliver, please take over. As it is a regression (I take that for granted without
checking it myself), we should try to fix it soon.
Comment 5 Oliver Specht 2008-12-01 09:38:30 UTC 
->mst: Your change in rev. 1.48 in swhtml.cxx is the reason.
ParseMetaOptions is only called for new documents. Encoding is detected within
this function.
Comment 6 mst.ooo 2008-12-01 15:49:20 UTC 
hmm, yes, it seems i got confused by this convoluted piece of code and how it
depends on an undocumented side effect... should have looked more closely.

only sw is affected because the code that sets the encoding is copy-pasted in sc
and dbaccess, despite being in the base class in sfx2... sigh.

fixed in cws sw301bf05
Comment 7 kpalagin 2008-12-01 16:08:42 UTC 
Great job, thanks a ton!
Will 3.0.1 get this fix too?
Comment 8 mst.ooo 2008-12-02 13:01:40 UTC 
let's see if we can get this into 3.0.1
Comment 9 kpalagin 2008-12-02 13:12:37 UTC 
I just love this attitude!
Comment 10 mst.ooo 2008-12-04 12:58:30 UTC 
please verify
Comment 11 michael.ruess 2008-12-09 08:52:24 UTC 
Verified in CWS sw301bf05.
Comment 12 michael.ruess 2009-01-13 11:42:19 UTC 
Checked in build OOO300m15 and DEV300m38.