Issue 96863 - ADDRESS adds quote around sheet, not only filename, breaks reference to other file (ADDRESS and INDIRECT functions not adaptable)
Summary: ADDRESS adds quote around sheet, not only filename, breaks reference to other...
Status: CLOSED FIXED
Alias: None
Product: Calc
Classification: Application
Component: programming (show other issues)
Version: OOO300m9
Hardware: All All
: P3 Trivial with 2 votes (vote)
Target Milestone: 3.4.0
Assignee: kla
QA Contact: issues@sc
URL:
Keywords: oooqa, regression
Depends on:
Blocks:
 
Reported: 2008-12-03 19:56 UTC by uluer
Modified: 2017-05-20 10:30 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
File which is called from the "target"-document (7.33 KB, application/vnd.oasis.opendocument.spreadsheet)
2008-12-03 22:45 UTC, Regina Henschel
no flags Details
Handling of file name in parameter has changed (26.82 KB, application/vnd.oasis.opendocument.spreadsheet)
2008-12-03 22:47 UTC, Regina Henschel
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description uluer 2008-12-03 19:56:45 UTC
If address pointed any where inside of the same calc file adaptation is okay. 
But, INDIRECT function give Error with generated address by ADDRESS function 
which is pointed to another calc file.

This address (generated by manually) acceptable by INDIRECT in OO3.0
'blabla.ods'#B.A1

This address (generated by ADDRESS) can not acceptable by INDIRECT in OO3.0
'blabla.ods#B'.A1

The ADDRESS and INDIRECT adaptation working well before OO3.0 on OO2.4

This issue founded on Turkish version of OO and not checked with english 
version.
Comment 1 Regina Henschel 2008-12-03 22:44:20 UTC
The error is already in ADDRESS. It seems that OOo3 has a different way for
ADDRESS to set the apostrophe, if the last parameter contains a file name.

Copy both attached files into the same directory. Open target.ods in OOo2.4 to
see that it works. Then open it in OOo3.0. The formulas generate wrong references.
Comment 2 Regina Henschel 2008-12-03 22:45:45 UTC
Created attachment 58487 [details]
File which is called from the "target"-document
Comment 3 Regina Henschel 2008-12-03 22:47:00 UTC
Created attachment 58488 [details]
Handling of file name in parameter has changed
Comment 4 gercokees 2009-02-23 08:58:48 UTC
probably the behaviour has changed in OOo 3.0
Now we need at least 5 parameters.

The documentation is also wrong for OOo 3.0
openoffice.org help {F1} > adress > spreadsheet functions > example:
ADDRESS(1; 1; 2; "Sheet2") returns the following: Sheet2.A$1
should be:
ADDRESS(1; 1; 2; 1; "Sheet2") returns the following: Sheet2.A$1
Comment 5 lohmaier 2009-09-21 11:34:50 UTC
confirmed, flagging as regression, not only windows affected, updated summary.

As described: when referencing another document in the table-parameter, the
address function in OOo 3.x adds the quotes at inappropriate places.
It includes the sheetname in the quoted part, which is not what other formulas
expect.

In addition, this is different from previous versions that did not add quotes at
all (the user had to specify them).

regression as this breaks documents that try to use indirect in combination with
address function to reference data from other files.

Even if it would add the quotes at the correct places, it would break formulas
that use CONCATENATE or similar that provide the quotes as it was necessary in
previous versions of OOo. as a name like
''file:///tmp/bug.ods''#Table1.A1

(i.e. double-quoted filename) will not be accepted by INDIRECT either.
Comment 6 ooo 2009-09-23 15:51:09 UTC
Grabbing issue. Might be worth nominating this as 3.2 stopper on releases@ooo
Comment 7 niklas.nebel 2011-02-28 11:33:40 UTC
Code change reviewed.
Comment 8 ooo 2011-03-03 13:07:45 UTC
In cws calc66:

changeset dceeb0488213 http://hg.services.openoffice.org/cws/calc66/changeset/dceeb0488213
M sc/inc/compiler.hxx
M sc/source/core/tool/address.cxx
M sc/source/core/tool/compiler.cxx
M sc/source/core/tool/interpr1.cxx

You can observe the progress and possible integration date of CWS calc66 at
http://tools.services.openoffice.org/EIS2/cws.ShowCWS?Path=DEV300%2Fcalc66
Comment 9 ooo 2011-03-15 13:27:03 UTC
Reassigning to QA for verification.
Comment 10 kla 2011-03-21 13:23:34 UTC
Seen ok in cws calc66 -> verified