Issue 97200 - MathML export should write valid MathML 2.0
Summary: MathML export should write valid MathML 2.0
Status: CLOSED FIXED
Alias: None
Product: Math
Classification: Application
Component: code (show other issues)
Version: OOo 1.0.0
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: michael.ruess
QA Contact: issues@sw
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-12 13:27 UTC by michael.brauer
Modified: 2013-08-07 14:56 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Sample odf files to test MathML export (42.00 KB, application/octet-stream)
2009-05-04 12:32 UTC, thomas.lange 		no flags Details
Document producing error on validation (11.49 KB, application/vnd.oasis.opendocument.text)
2009-05-07 14:54 UTC, michael.ruess 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description michael.brauer 2008-12-12 13:27:10 UTC 
The MathML export adds namespace prefixes to XML attributes. According the the
MathML schema, the attributes must not have a namespace prefix.
Comment 1 thomas.lange 2009-04-23 08:41:33 UTC 
.
Comment 2 thomas.lange 2009-04-23 11:36:18 UTC 
Files changed:
- starmath\source\mathml.cxx
Comment 3 thomas.lange 2009-04-23 11:47:38 UTC 
In agreement with MIB and MT it was diecided that the Math.dtd should be removed
from the installation set as well since it
a) has incorrect content
b) is no longer used nowadays at all

Files changed:
scp2:
M      source\math\module_math.scp
M      source\math\file_math.scp
Comment 4 thomas.lange 2009-04-28 10:25:25 UTC 
Files changed:
xmloff:
M      source\core\nmspmap.cxx
M      source\core\xmlexp.cxx
M      inc\xmloff\xmlexp.hxx
starmath:
M      source\mathml.cxx
Comment 5 thomas.lange 2009-04-29 10:14:29 UTC 
Breaking up mathml.hxx/cxx into separate files for import and export.

Files changed:
D      source\mathml.hxx
D      source\mathml.cxx
A      source\mathmlimport.hxx
A      source\mathmlimport.cxx
A      source\mathmlexport.hxx
A      source\mathmlexport.cxx
M      source\view.cxx
M      source\document.cxx
M      source\makefile.mk
Comment 6 thomas.lange 2009-04-29 13:58:17 UTC 
Files changed:
- xmloff/inc/xmloff/xmltoken.hxx
- xmloff/source/core/xmltoken.cxx
Comment 7 thomas.lange 2009-05-04 09:56:45 UTC 
Changed summary to reflect the new goal.

A ODF validator to verify this issue is
http://tools.odftoolkit.org/odfvalidator/
Comment 8 thomas.lange 2009-05-04 12:30:05 UTC 
Fixed in CWS tl66.

Additional files changed:
starmath:
M      source\mathmlexport.cxx
M      source\accessibility.cxx
M      source\mathmlexport.hxx
M      source\parse.cxx
M      source\unomodel.cxx
M      source\node.cxx
M      source\types.cxx
M      source\mathmlimport.cxx
M      inc\unomodel.hxx
M      inc\node.hxx
Comment 9 thomas.lange 2009-05-04 12:32:28 UTC 
Created attachment 61978 [details]
Sample odf files to test MathML export
Comment 10 thomas.lange 2009-05-04 12:39:11 UTC 
TL->MRU: To use the testcase do the following for all of them:
- first load them in the office from the CWS 
- modify them a little by adding a new character
- save the new file
- check the result with the odf validator (see link above)

Don't forget to check that 
- older math formulas still can get properly read with this CWS
- and that older offices should still be able to read the new formulas
  written by this CWS

If you have very much time at hand you can also check if the visual result of
the pure MathML export (saving as .mml) is about the same as before.
Ask how to do that if interested.
Comment 11 thomas.lange 2009-05-05 10:06:18 UTC 
.
Comment 12 michael.ruess 2009-05-07 14:54:25 UTC 
Created attachment 62077 [details]
Document producing error on validation
Comment 13 michael.ruess 2009-05-07 14:57:35 UTC 
Reopening; newly attached doc gives error "The content of element 'munderover'
is not complete." on validation.
Comment 14 michael.ruess 2009-05-07 15:00:43 UTC 
Reassigned to TL.
Comment 15 thomas.lange 2009-05-08 06:52:04 UTC 
Missing problem fixed as well.
Comment 16 thomas.lange 2009-05-08 06:54:30 UTC 
.
Comment 17 michael.ruess 2009-05-08 11:00:14 UTC 
New build now survives the ODF validation with en even more complex document.
Comment 18 michael.ruess 2009-12-01 14:18:45 UTC 
Checked integration with OOO320m6.