Issue 97339 - gtk text boxes aren't highlighted like in native gtk applications
Summary: gtk text boxes aren't highlighted like in native gtk applications
Alias: None
Product: gsl
Classification: Code
Component: code (show other issues)
Version: OOO310m11
Hardware: Unknown All
: P3 Trivial (vote)
Target Milestone: OOo 3.x
Assignee: AOO issues mailing list
QA Contact:
Depends on:
Reported: 2008-12-17 07:26 UTC by ht990332
Modified: 2013-07-30 02:19 UTC (History)
4 users (show)

See Also:
Latest Confirmation in: ---
Developer Difficulty: ---

native gtk input box (4.37 KB, text/plain)
2008-12-17 07:27 UTC, ht990332
no flags Details
gtk themes (48.04 KB, image/jpeg)
2009-04-24 19:30 UTC, ht990332
no flags Details
maybe this is the roughtly the right thing to do (1.15 KB, patch)
2009-05-01 14:32 UTC, caolanm
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description ht990332 2008-12-17 07:26:12 UTC
Some gtk themes highlight text/input boxes. Openoffice's gtk integration/look
doesn't do that. I'll attach a screenshot of a native gtk application.
Comment 1 ht990332 2008-12-17 07:27:40 UTC
Created attachment 58876 [details]
native gtk input box
Comment 2 stefan.baltzer 2009-04-24 15:26:28 UTC
Change type from "Defect" to "Enhancement". Being a "good citizen" on all
platforms is a valuable goal, but being slightly behind is not automatically a
Put CMC, PL and myself on C/C.

SBA->CMC: Is this one already on someones "good GTK citizen" list?

SBA->CMC/PL: Is a solution WITHOUT UI change possible?
...that wohld make a feature and (all its pain :-) of this.
Comment 3 stefan.baltzer 2009-04-24 15:27:16 UTC
Add CCs.
Comment 4 philipp.lohmann 2009-04-24 15:43:15 UTC
Could you please state which specific gtk theme that is ? And on what Gnome and
what linux it is available ? And what does OOo's gtk plugin look like in that
theme ?
Comment 5 ht990332 2009-04-24 19:30:09 UTC
Created attachment 61800 [details]
gtk themes
Comment 6 ht990332 2009-04-24 19:31:32 UTC
I attached a image. this is under gnome 2.26 and murrine gtk engine. Same exact
thing happens under gnome's default gtk clearlooks theme.
Comment 7 caolanm 2009-05-01 14:31:07 UTC
Can confirm this anyway, and it would be a gsl thing to allow it to be drawn
Comment 8 caolanm 2009-05-01 14:32:35 UTC
Created attachment 61943 [details]
maybe this is the roughtly the right thing to do
Comment 9 caolanm 2009-05-01 14:33:37 UTC
not sure if this is the right solution, but it does seem to give me
correct-looking focus rectangles
Comment 10 philipp.lohmann 2009-05-04 09:53:48 UTC
that looks promising (that is similar to what the mac does, from which the blue
focus rings are "inspired" anyway). But setting mbNoFocusRects to true means
that in the gtk case focus rects will not be drawn anywhere; that is probably
not the right thing to do in most themes.
Comment 11 caolanm 2009-05-04 12:50:28 UTC
I'm not too sure how its supposed to work at the moment, but AFAICS the
gtkeditbox painter NWPaintOneEditBox never gets a "focused" state at the moment,
so its not possible for it to ever paint itself as focused as that bit
ironically is not set unless.

        else if( mbNWFBorder )
            if( pCtrl->HasFocus() || pCtrl->HasChildPathFocus() )
                nState |= CTRL_STATE_FOCUSED;

inside brdwin.cxx
Comment 12 philipp.lohmann 2009-05-04 13:11:16 UTC
That bit is added for the mac (which is currently the only platform with
mbNWFBorder). This also controls other related things like asking NWF for the
width of said border (e.g. on the mac the blue ring is on the outside, so there
needs to be space for it). Currently the mac is the only platform with native
focus marking (the blue rings), all other focusing is done via the normal vcl
method, which paints a dotted line around the focused control (e.g. checkboxes
radiobuttons, listbox entries) or at least some text contained (e.g. push buttons).
Comment 13 ht990332 2009-05-18 20:03:50 UTC
the patch works really nicely :)
Comment 14 Rob Weir 2013-07-30 02:19:02 UTC
Reset assignee on issues not touched by assignee in more than 2000 days.