Issue 97399 - Extraneous polygon edges on pdf export for DXF
Summary: Extraneous polygon edges on pdf export for DXF
Status: CLOSED FIXED
Alias: None
Product: gsl
Classification: Code
Component: code (show other issues)
Version: OOo 3.0
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 3.1
Assignee: h.ilter
QA Contact: issues@gsl
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2008-12-18 15:35 UTC by thb
Modified: 2009-04-23 15:19 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
hackaround (4.09 KB, patch)
2009-01-14 16:34 UTC, thb 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description thb 2008-12-18 15:35:54 UTC 
See $subject. Insert the dxf drawings from
http://www.schiwa.de/OOo/dxf-beispiele/ into a doc & export to pdf -> results in
very funny extra edges. Worked in 2.x, broke for 3.0
Comment 1 thb 2008-12-18 15:43:59 UTC 
target
Comment 2 philipp.lohmann 2008-12-18 15:49:45 UTC 
add keyword, version
Comment 3 thb 2009-01-14 16:34:37 UTC 
Created attachment 59383 [details]
hackaround
Comment 4 thb 2009-01-14 16:42:40 UTC 
@pl: turns out drawArc() had start/end angle almost equal, and floating point
arith went south. Hackaround attached, was about to swap in
basegfx::tools::createPolygonFromEllipseSegment() instead (which properly
handles a lot of corner cases, including this one), but then got stuck in the
minutiae of outputting a B2DPolyPolygon to bezier, and keeping existing
semantics & bugfixes...
Comment 5 philipp.lohmann 2009-01-14 16:51:20 UTC 
interesting. would it be feasible in this degenerate case to replace the drawArc
by a drawCircle or skip the arc part wholesale depending on which of start and
stop angle is greater ? Would we be able to reliably detect which case was
requested, circle or nothing ?
Comment 6 thb 2009-01-14 19:35:17 UTC 
Yep, drawCirlce() would work, ultimately we'd need to check how the tools
polygon behaves in these corner cases (might also be the empty arc) - so it's
not that bad now, the code currently errs on the "empty arc" side, and just
renders the line to the center if chord is requested.

But before adding more tweaks, I'd go for basegfx probably.

@pl: any CWS at hand I could put this into (the existing fix)?
Comment 7 thb 2009-01-15 09:59:54 UTC 
Fixed in CWS vcl98.
Comment 8 philipp.lohmann 2009-01-26 11:10:37 UTC 
please verify in CWS vcl98
Comment 9 h.ilter 2009-01-26 14:18:03 UTC 
Verified with cws vcl98 = ok
Comment 10 h.ilter 2009-04-23 15:19:05 UTC 
Still ok in OOo3.1RC1