Apache OpenOffice (AOO) Bugzilla – Issue 98069
Assertion: "PageSelector::DeselectAllPages: the selected pages counter is not 0"
Last modified: 2010-02-22 15:09:14 UTC
How to reproduce: 1 Create new Impress document with non-pro Office. 2 Switch view to handout mode and back to normal.
Fixed type in summary.
The main part of the fix consisted of reordering two lines in SlideSorterModel::SetEditModeFromController() causing the page list to be updated before the page descriptor list is rebuild and thus can reflect the new pages. Modified files are: sd\source\ui\slidesorter\controller\SlideSorterController.cxx sd\source\ui\slidesorter\controller\SlsListener.cxx sd\source\ui\slidesorter\controller\SlsListener.hxx sd\source\ui\slidesorter\inc\controller\SlideSorterController.hxx sd\source\ui\slidesorter\model\SlideSorterModel.cxx Revision 266295
Forgot to make the inner class SlideSorterController::ModelChangeLock a friend of SlideSorterController after making some methods in the later private. Modfiied file is sd/source/ui/slidesorter/inc/controller/SlideSorterController.hxx rev. 266588
Ahm, there has been a little problem with my previous changes. Acquiring a SlideSorterController::ModelLock lead to a call to PreModelChange() in every case. This clears the page selection and operations that work on the selected pages and used a ModelLock became noops. Fixed by making calls to PreModelChange() optional again. Modified files are: sd/source/ui/slidesorter/controller/SlideSorterController.cxx sd/source/ui/slidesorter/inc/controller/SlideSorterController.hxx rev. 266635
the changes looks good -> verified.
This issue is closed automatically. It should be fixed in a version with is available for longer than half a year (OOo 3.1). If you think this issue isn't fixed in the current version (OOo 3.2) please reopen it. But then please pay attention about the field 'target milestone'. The closure was approved by the Release Status Meeting at 22nd of February 2010 and it is based on the issue handling guideline for fixed/verified issues : http://wiki.services.openoffice.org/wiki/Handle_fixed_verified_issues