Issue 98069 - Assertion: "PageSelector::DeselectAllPages: the selected pages counter is not 0"
Summary: Assertion: "PageSelector::DeselectAllPages: the selected pages counter is not 0"
Alias: None
Product: Impress
Classification: Application
Component: code (show other issues)
Version: DEV300m38
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 3.1
Assignee: groucho266
QA Contact: issues@graphics
Depends on:
Blocks: 97634
  Show dependency tree
Reported: 2009-01-14 12:07 UTC by groucho266
Modified: 2010-02-22 15:09 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Note You need to log in before you can comment on or make changes to this issue.
Description groucho266 2009-01-14 12:07:06 UTC
How to reproduce:
1 Create new Impress document with non-pro Office.
2 Switch view to handout mode and back to normal.
Comment 1 groucho266 2009-01-14 12:15:39 UTC
Fixed type in summary.
Comment 2 groucho266 2009-01-14 12:43:55 UTC
The main part of the fix consisted of reordering two lines in
SlideSorterModel::SetEditModeFromController() causing the page list to be
updated before the page descriptor list is rebuild and thus can reflect the new

Modified files are:
Revision 266295
Comment 3 groucho266 2009-01-20 14:28:59 UTC
Forgot to make the inner class SlideSorterController::ModelChangeLock a friend
of SlideSorterController after making some methods in the later private.

Modfiied file is sd/source/ui/slidesorter/inc/controller/SlideSorterController.hxx
rev. 266588
Comment 4 groucho266 2009-01-21 09:46:36 UTC
Ahm, there has been a little problem with my previous changes.  Acquiring a
SlideSorterController::ModelLock  lead to a call to PreModelChange() in every
case.  This clears the page selection and operations that work on the selected
pages and used a ModelLock became noops.

Fixed by making calls to PreModelChange() optional again.

Modified files are:
rev. 266635
Comment 5 sven.jacobi 2009-01-21 14:12:52 UTC
the changes looks good -> verified.
Comment 6 thorsten.ziehm 2010-02-22 15:09:14 UTC
This issue is closed automatically. It should be fixed in a version with is
available for longer than half a year (OOo 3.1). If you think this issue isn't
fixed in the current version (OOo 3.2) please reopen it. But then please pay
attention about the field 'target milestone'.
The closure was approved by the Release Status Meeting at 22nd of February 2010
and it is based on the issue handling guideline for fixed/verified issues  :