Issue 98176 - Request Landscape Style be in Available Calc Styles
Summary: Request Landscape Style be in Available Calc Styles
Status: CONFIRMED
Alias: None
Product: Calc
Classification: Application
Component: ui (show other issues)
Version: OOO300m9
Hardware: All All
: P3 Trivial with 1 vote (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-17 21:09 UTC by joeconner
Modified: 2015-01-15 15:29 UTC (History)
5 users (show)

See Also:
Issue Type: ENHANCEMENT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Calc Landscape Template (9.53 KB, application/vnd.oasis.opendocument.spreadsheet)
2009-01-17 21:20 UTC, joeconner 		no flags Details
Patch to add landscape page style for Calc (3.94 KB, patch)
2014-05-18 12:16 UTC, hanya 		no flags Details | Diff
File contains landscape style that added by the attached patch (7.65 KB, application/vnd.oasis.opendocument.spreadsheet)
2015-01-14 15:21 UTC, hanya 		no flags Details
Patch to add landscape page style for Calc (5.46 KB, patch)
2015-01-15 15:29 UTC, hanya 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description joeconner 2009-01-17 21:09:49 UTC 
Problem: A calc document without numerous sheets can need Landscape for selected
sheets and Portrait for others.  Changing to Landscape in the print preview
modifies all sheets, not just the one being previewed.

Using F11 to bring up the styles does not present a landscape style.  Each calc
user in the world wishing to have such a style must build it for themselves. 
Landscape is already available in Writer.  Why not Calc?  This would be a very
valuable enhancement for the available standard Calc styles.

For that matter, Why does F11 in writer produce many more style choices than in
Calc?
Comment 1 joeconner 2009-01-17 21:20:04 UTC 
Created attachment 59446 [details]
Calc Landscape Template
Comment 2 joeconner 2009-11-19 07:33:57 UTC 
Why has no one acknowledged this issue?  Is a Landscape style ever going to be
added to CALC?
Comment 3 Edwin Sharp 2013-12-12 16:10:53 UTC 
Useful enhancement.
Comment 4 hanya 2014-05-18 12:16:28 UTC 
Created attachment 83413 [details]
Patch to add landscape page style for Calc

With swapped page width and height from the default paper size with landscape flag.
Comment 5 hanya 2015-01-14 15:21:43 UTC 
Created attachment 84416 [details]
File contains landscape style that added by the attached patch

The attached file that contains new landscape style stored by the office the patch applied, 
have to be opened without any problems on older version.
Comment 6 Regina Henschel 2015-01-14 17:13:42 UTC 
I have not applied the patch, but from the code I see two questions in the patch:

(1)
The new style is missing in ScStyleSheetPool::CopyStdStylesFrom( ScStyleSheetPool* pSrcPool )
see comment
   //  neue Eintraege auch bei CopyStdStylesFrom eintragen
at the beginning of ScStyleSheetPool::CreateStandardStyles()
The comment means translated, "put new items into CopyStdStylesFrom too".

(2)
Line
pSheet->SetParent( aStrStandard );

??? DO have page styles a parent? That is not possible in the UI.
Comment 7 hanya 2015-01-14 17:57:05 UTC 
(In reply to Regina Henschel from comment #6)
> (1)
> The new style is missing in ScStyleSheetPool::CopyStdStylesFrom(
> ScStyleSheetPool* pSrcPool )
> see comment
>    //  neue Eintraege auch bei CopyStdStylesFrom eintragen
> at the beginning of ScStyleSheetPool::CreateStandardStyles()
> The comment means translated, "put new items into CopyStdStylesFrom too".
Thank you. I did not notice the comment. 

> (2)
> Line
> pSheet->SetParent( aStrStandard );
> 
> ??? DO have page styles a parent? That is not possible in the UI.
It seems it is not required. Landscape style is not child of Default style in Writer. I will remove it.
Hierarchical structure of cell style can be changed with UI by drag and drop on 
hierarchical mode of Styles and Formatting. But it can not be done with page style.
Comment 8 hanya 2015-01-15 15:29:55 UTC 
Created attachment 84428 [details]
Patch to add landscape page style for Calc

Update the patch.