Issue 98410 - Wrong Kashida justification for ZWNJ (U200C)
Summary: Wrong Kashida justification for ZWNJ (U200C)
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: formatting (show other issues)
Version: DEV300m39
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: stefan.baltzer
QA Contact: issues@sw
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-23 15:54 UTC by hdu@apache.org
Modified: 2013-08-07 14:43 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
minimal bugdoc (11.45 KB, application/vnd.oasis.opendocument.text)
2009-01-23 15:56 UTC, hdu@apache.org
no flags Details
patch for sw/source/core/text/porlay.cxx (804 bytes, patch)
2009-01-24 17:38 UTC, hennerdrewes
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description hdu@apache.org 2009-01-23 15:54:03 UTC
When testing the problem in issue 28203 hossenabad found a different issue with kashida justification:
"Another problem is with U200C [ZERO WIDTH NON-JOINER]. I use OOo 3.0.1 on Ubuntu Linux. In jom.odt 
that h15n has attached, ZERO WIDTH NON-JOINERs that are between Arabic sin or shin and other letters, 
it is appeared as Kashida. However this situation is appeared for some font sizes but for sontsizes below a
specific value it is not appeared."

Confirmed on DEV300_m39 which contains CWS kashidafix. Also confirmed in CWS kashidafix02 (which 
already contains a fix for the similar issue 97108). Though the kashida is only visible on UNX platforms 
the very problem that a zero-width-xxx gets expanded by a justification seems to be the real problem.
Comment 1 hdu@apache.org 2009-01-23 15:56:03 UTC
Created attachment 59631 [details]
minimal bugdoc
Comment 2 hennerdrewes 2009-01-23 16:35:16 UTC
The problem could have its roots 

1. in the kashida search in porlay.cxx. As far as I recall the code, a ZWNJ
should actually prevent a kashida position. But to be on the safe side, I will
test this once more.

2. As the problem is visible only on UNX, I have another idea: 

(@hdu:) usp adds a blank glyph with zero advance width at the ZWNJ position. I
guess, this in addition with all uJustification info prevents the kashida
appearance. It would be interesting to know how this is handled by ICU and the
kashida injection code.
Comment 3 hdu@apache.org 2009-01-23 16:59:04 UTC
@hennerdrewes: thanks for looking into this! Yes, if the extra space for the zero-width space really makes 
sense, I could easily suppress the injection of the kashida glyph on UNX. But does it make sense? IMHO a 
zero-width-glyph should stay exactly... (drum-roll please) at a width of exactly zero.
Comment 4 hennerdrewes 2009-01-23 18:18:01 UTC
@hdu: you are right. Something is wrong here.
Comment 5 hennerdrewes 2009-01-23 18:40:42 UTC
oh yes of course: for the 2nd priority (after Seen or Sad) the code doesn't
check which character is following. 
Comment 6 hennerdrewes 2009-01-24 17:38:03 UTC
Created attachment 59644 [details]
patch for sw/source/core/text/porlay.cxx
Comment 7 frank.meies 2009-01-26 09:18:26 UTC
@hdu: Looks good for me. Please proceed.
Comment 8 hdu@apache.org 2009-01-26 11:06:03 UTC
Applied in CWS kashidafix02.
Comment 9 hdu@apache.org 2009-01-27 15:11:49 UTC
@sba: please verify in CWS kashidafix02 (also use the bugdoc hossenabad mentioned in issue 28203)
Comment 10 hdu@apache.org 2009-01-27 15:16:05 UTC
adjusted target to CWS
Comment 11 stefan.baltzer 2009-01-30 12:02:57 UTC
Verified in CWS kashidafix02.
Comment 12 thorsten.ziehm 2010-02-22 14:47:06 UTC
This issue is closed automatically. It should be fixed in a version with is
available for longer than half a year (OOo 3.1). If you think this issue isn't
fixed in the current version (OOo 3.2) please reopen it. But then please pay
attention about the field 'target milestone'.
The closure was approved by the Release Status Meeting at 22nd of February 2010
and it is based on the issue handling guideline for fixed/verified issues  :
http://wiki.services.openoffice.org/wiki/Handle_fixed_verified_issues