Issue 98859 - Custom animation "Change Font Size" cannot save font size setting
Summary: Custom animation "Change Font Size" cannot save font size setting
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: editing (show other issues)
Version: OOO300m9
Hardware: Unknown All
: P3 Trivial (vote)
Target Milestone: OOo 3.2
Assignee: wolframgarten
QA Contact: issues@graphics
URL:
Keywords:
Depends on: 102534
Blocks: 84292
  Show dependency tree
 
Reported: 2009-02-04 08:32 UTC by doze_worm
Modified: 2009-07-16 11:16 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description doze_worm 2009-02-04 08:32:41 UTC 
[Steps]
1. Create an Impress doc.
2. Apply "Title Slide" layout, and type several words in the text area. Select
the words, add custom animation "Change Font Size" to them, and set tiny,
smaller or extra large in "Font size" of the animation. Save and close the
Impress doc.
3. Reopen the Impress doc, switch to Custom Animation bar and click the
animation which added in step 2.

[Result]
The "Font size" setting becomes gray, and the animation doesn't have effection
when play.

[Addition]
Once you edit the "Font size" in "Change Font Size" animation, save and reload
the doc will lead to lost the "Font size" setting. But if add "Change Font Size"
animation with default setting, "larger", the "Font size" setting will keep
after the doc reload.

Tested in DEV300m41 both on Windows and Linux.
Comment 1 wolframgarten 2009-02-04 09:04:14 UTC 
Reproducible. Reassigned.
Comment 2 groucho266 2009-04-08 15:52:28 UTC 
The font size, a value relative to its original size, is written in
XMLCharHeightHdl::exportXML (xmloff/source/style/chrhghdl.cxx) as absolute point
size (pt).  When written correctly (150% is mapped to 1.5pt) then the absolute
size is mapped correctly back to the relative size.

The exportXML() method, however, can handle only float values.  For some reason
some relative font sizes like 400% (extra large) is stored as double value in
the Any that is passed to exportXML().  The double value is not recognized and
therefore an empty string is written to file.

Adding support for double values in the exportXML() method fixes this problem.

@cl: I am not quite sure whether the absolute/relative conversion is a bug or a
feature or whether restricting exportXML() to just float values is a bug or a
feature.  Can you shed some light on this?
Comment 3 clippka 2009-04-16 15:32:48 UTC 
actualle the type was wrong, I replaced it with a double percentage type.

fixed in cws impress171 for OOo 3.2
Comment 4 clippka 2009-06-03 16:34:16 UTC 
verified in cws, back to qa
Comment 5 wolframgarten 2009-06-05 11:12:32 UTC 
Verified in CWS. Found i102534.
Comment 6 wolframgarten 2009-07-16 11:16:10 UTC 
Tested in m52. Closed.