Apache OpenOffice (AOO) Bugzilla – Issue 98970
Fix visual area handling for Calc, Draw and Impress embedded objects during outplace editing.
Last modified: 2017-05-20 10:47:54 UTC
See $subject. Core stuff was ~mostly there, added a few tweaks + UI to select outplace mode optionally.
Created attachment 59988 [details] The patch
Outplace editing was left out by intent as it didn't work correctly. The main reason was that resizing could totally ruin the object. IIRC this was mainly a problem in Draw/Impress, but to a lesser extent also in Writer. Did you test that this works fine?
@mba: if you refer to the aspect ratio mess-up - yeah, that's catered for & works here (see the visarea mods in the patch)
OK, there's still a problem in Writer, but it's not so serious. We will give the patch a try.
Change target to 3.2. Means: that would be the version to integrate it in case it can be applied "as is". Everything else of course depends on how fast found problems can be fixed.
There is a new UI to activate object outplace in the patch. Whether UI good or bad is a matter of taste. But since we have already a standard way to use a specific verb for and embedded object ( popup menu ), this way should be used. To change the UI design please submit a feature request. Thus I am going to throw the new UI away from the patch and just activate the "OPEN" verb is it was designed from the beginning. The changes for the sd project are still very valuable ( if it works ), since these applications were actually the main reason to deactivate the outplace editing. Changing the Summary accordingly.
Created attachment 62876 [details] I have removed the UI part from thb patch, this is what I have got. Please review.
The "PluginMode" related changes were removed from the patch as well. The value 2 was till now used for the floating frame objects, so the change misuses the value. The property has nothing to do with the com.sun.star.plugin.PluginMode UNO enumeration. I agree that it might be quite confusing.
Unfortunately the patch does not help against one of the main problems with the visual area. If the object is opened outplace and closed, the position of the document contents changes itself. And if the draw document is inserted from a file, the problems with outplace activation are most visible. The problem here seems to be that there is no real way to control the visual area of the document. As result the mix from "outer" and "inner" size that are set internally let the visual area behave relative unpredictable. I have investigated the mechanics some years ago, and did not find a solution in timeframe that I had. It could be that the situation is better now, unfortunately I have not much time to investigate the problem. By the way, to activate the outplace open verb in UI please set the configuration value org.openoffice.Office.Embedding/Verbs/OPEN/VerbAttributes to 2 instead of 0, that will let the verb appear in UI with "Open" text. So unfortunately the patch still does not allow to activate the outplace editing. Setting the issue back to defect and changing the task to OOo3.x for now. But if there would be a solution to the visual area problem it will be integrated in OOo3.2 with activated outplace editing I assume.
@mav: thanks a lot for this very extensive review. I'll try to have a deeper look at it, though currently quite busy with other stuff...
*** Issue 112137 has been marked as a duplicate of this issue. ***
Reset assigne to the default "issues@openoffice.apache.org".