Issue 99922 - Error message when making 'Save as...' with KDE plugin.
Summary: Error message when making 'Save as...' with KDE plugin.
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: OOO310m4
Hardware: All Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 3.1
Assignee: Olaf Felka
QA Contact: issues@framework
URL:
Keywords: regression
Depends on:
Blocks: 95768
  Show dependency tree
 
Reported: 2009-03-05 13:19 UTC by Olaf Felka
Modified: 2009-03-26 15:56 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
tentative fix (1.27 KB, patch)
2009-03-05 17:52 UTC, philipp.lohmann
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description Olaf Felka 2009-03-05 13:19:53 UTC
- create a new document
- make 'File -> Save as...'
- an error message pops up: "Error saving the Document Untitked1: The operation
on file:/<path to $HOME>/Documents was started with an invalid parameter"
Comment 1 Olaf Felka 2009-03-05 13:21:52 UTC
of: Has been ok in m3.
Comment 2 Olaf Felka 2009-03-05 13:51:23 UTC
of: It is the same for 'File -> Save' and 'Save All'
Comment 3 Olaf Felka 2009-03-05 14:12:08 UTC
of: Seems to be KDE related problem.
Comment 4 philipp.lohmann 2009-03-05 17:51:06 UTC
- observation: reported difference between "root" install and "user script"
install does not exist
- observation: the kde plugin has no hand in this

However the configuration backend for kde only gets active if the kde vcl plugin
gets loaded (hence the dependence of the issue on the kde plugin). The config
backend reads the default path to store to ($HOME/Documents) from KDE's
KGlobalSettings. This is a file path that was converted to a URL by prepending
"file:" to the path resulting in something like "file:/home/username/Documents".
This has been so since at least 2006, but somehow has worked up to now;
apparently we are now less fault tolerant to strange URLs. Converting the path
using osl_getFileURLFromSystemPath should result in OOo compaitble URLs. Will
attach a patch to shell/source/backends/kdebe/kdepathslayer.cxx that does this
(and fixed the problem for me).

pl->of: please check if this works also with "curious" user names like "Èric" or
"られる" containing non-ascii characters.

all: who owns the configuration backends nowadays anyway ?
Comment 5 philipp.lohmann 2009-03-05 17:52:14 UTC
Created attachment 60754 [details]
tentative fix
Comment 6 philipp.lohmann 2009-03-05 19:39:04 UTC
I haven't thought of this before: how often are the config backends invoked ?
They probably should be all the time, so the fix would work always. However if
they were only invoked once (e.g. on first start) we would have lots of user
configurations containing a URL of the wrong form and the new form wouldn't get
updated. We need to check this.
Comment 7 mikhail.voytenko 2009-03-06 13:15:31 UTC
mav->pl: Thank you for the patch and for the stack you have sent. The patch is
integrated and additionally I have adjusted the sfx2 so that the caches path
should not cause problems any more.
Comment 8 mikhail.voytenko 2009-03-09 12:26:58 UTC
mav->of: Please verify the issue. Additionally please test the scenario from
issue 99680. It is affected by the fix.
Comment 9 mikhail.voytenko 2009-03-09 12:33:13 UTC
.
Comment 10 Olaf Felka 2009-03-11 14:49:32 UTC
of: Fix verified in cws mav48.
Comment 11 Olaf Felka 2009-03-11 14:54:17 UTC
verified
Comment 12 Olaf Felka 2009-03-26 15:56:12 UTC
Looks good in ooo310_m7