Issue 99937 - [Redlining] Change of author (User name) disregarded when changed during Office session
Summary: [Redlining] Change of author (User name) disregarded when changed during Offi...
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: ui (show other issues)
Version: OOO310m4
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: eric.savary
QA Contact: issues@sw
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2009-03-05 23:33 UTC by max.odendahl
Modified: 2017-05-20 11:41 UTC (History)
6 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description max.odendahl 2009-03-05 23:33:28 UTC
- new writer doc
- enable change tracking
- write some stuff
- change user data
- write some stuff again

-> should have different colors, but all authors have the same color

It seems the reason is that in SwModule::GetRedlineAuthor(), bAuthorInitialised
is true for all following authors, therefore it always returns the index of the
first author and all get the same color.

Root cause seems to be that no SFX_HINT_USER_OPTIONS_CHANGED is sent, which
would set bAuthorInitialised to FALSE again inside SwModule::Notify.

Seems like configitems02_svn integrated into m38 caused this regression
Comment 1 max.odendahl 2009-03-05 23:34:12 UTC
I set the regression keyword, I guess also a 3.1 showstopper?
Comment 2 eric.savary 2009-03-06 11:02:23 UTC
@MOD: I do agree this is a stopper.

@OD: please have a look
Comment 3 Oliver-Rainer Wittmann 2009-03-06 12:29:20 UTC
OD->OS: Please take over as discussed.
Comment 4 Oliver Specht 2009-03-06 12:58:40 UTC
This may be anything but not a show stopper. Changing the author while editing
with redlining is not a typical use case. Therefore I change the target to 3.2

The change of svtools/source/config/useroptions.cxx in cws configitems02_svn has
broken the notification. The issue was 51626

Comment 5 stefan.baltzer 2009-04-08 15:42:12 UTC
Adjusting summary to reflect the findings and to ease queries.
The colour is only to mark different authors. 
The Tip help showing the authors name shows the "old author", too.
I also regard this as not a real user scenario.

I put HDE on cc because this one affects AutoTests.
Comment 6 Oliver Specht 2009-06-16 14:02:02 UTC
Fixed in cws os132 in
svtools/source/config/useroptions.cxx
Comment 7 Oliver Specht 2009-07-13 14:47:53 UTC
Reassigned for verification
Comment 8 eric.savary 2009-07-14 08:55:42 UTC
Verified in CWS os132.