Created attachment 26559 [details] Patch to support durable subscriptions to JMS Subscriber Sampler Here is a patch that adds support for durable subscriptions to the JMS Subscriber Sampler. It was created against trunk as of yesterday morning (revision 1063734). This is my very first contribution of this kind, and although I have spent quite some time going through various documentation, I may well have missed some guideline.
Thanks! Patch looks generally OK from a visual inspection. It would be helpful to also have a patch for the documentation, i.e. component_reference.xml, which explains what the new field does. BTW, the getProperty() and setProperty() methods have versions which provide defaults. The get default can be used to ensure the value is not null. The set default is useful to ensure that the property is not added to JMX files if it is empty. Obviously the same defaults must be used! We try to use this for new properties, otherwise the JMX files keep growing. No need to update the patch - that can be fixed later.
Created attachment 26573 [details] Patch to support durable subscriptions to JMS Subscriber Sampler Revised patch: - updated component_reference.xml - uses setProperty() with default
Created attachment 26574 [details] Screenshot of JMS Subscriber sampler Shows the "Durable Subscription ID" field
(In reply to comment #2) > Created an attachment (id=26573) [details] > Patch to support durable subscriptions to JMS Subscriber Sampler > > Revised patch: > - updated component_reference.xml > - uses setProperty() with default The patch file is identical to the previous one - wrong file attached?
Created attachment 26772 [details] Patch to support durable subscriptions to JMS Subscriber Sampler (v3) Sorry for the mess and the delay. This patch should hopefully be ok now
Thanks, the patch fixes the JMX file defaults. Still no sign of a patch for component_reference.xml however. If you have done the work, please attach a separate patch containing just that.
Created attachment 26784 [details] Addendum to patch v3 with component_reference.xml And here the missing component_reference.xml. Thanks for catching that!
Thanks, committed: URL: http://svn.apache.org/viewvc?rev=1082871&view=rev Log: Bug 50666 - JMSSubscriber: support for durable subscriptions
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/2459