Created attachment 26575 [details] Fold unneeded warn logging into debug logging When using the feature to merge HeaderManagers, e.g. using a general instance and then sample specific ones, there's a warn log statement issued for each sample. This fills the log quickly, makes it hard to find serious messages in the log file and doesn't actually add usueful information. The attached patch merges the problematic warn logging into the existing debug logging. The fact that merging is being done doesn't seem to warrant a warn message, since it is a supported feature documented by the component reference page. Thanks for the good work on JMeter!
Thanks. I think downgrade the log level is just sufficient. URL: http://svn.apache.org/viewvc?rev=1065240&view=rev Log: Bug 50686 - HeaderManager logging to verbose when merging instances Downgrade to debug Modified: jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java jakarta/jmeter/trunk/xdocs/changes.xml
Hi Milamber, thanks for downgrading the message. Please reconsider merging the two debug log statements: - The missing isDebugEnabled() for the first call makes it more expensive than necessary. The whole argument formatting will be done before calling debug() for every sample, even if debug logging is not activated. - The two debug messages are redundant and joining them into one message reduces debug log volume without removing any information from the log Thanks again! Rainer
Fixed: URL: http://svn.apache.org/viewvc?rev=1065299&view=rev Log: Bug 50686 - merge separate debug statements
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/2463