Bug 52503 - Unify File->Close and Window close file saving behaviour
Summary: Unify File->Close and Window close file saving behaviour
Status: RESOLVED FIXED
Alias: None
Product: JMeter - Now in Github
Classification: Unclassified
Component: Main (show other bugs)
Version: 2.5.1
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-23 16:03 UTC by immanuel.hayden
Modified: 2012-01-25 22:36 UTC (History)
1 user (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description immanuel.hayden 2012-01-23 16:03:12 UTC 
Observation: When you have an open test plan which has some unsaved edits the behaviour of File->Close [1] and closing the window [2] diverts. Both show the "do you want to save the changes?" dialogue, but then:
* [1] shows a file save dialogue
* [2] just saves the file (I prefer this).

Rant: The problem with the File->Close approach esp. as it opens the file save dialogue at some default location that is not the file path and also does not put the file name in the naming field.

Conclusion: I would love if this behaviour was unified, preferably to the close window behaviour because of the stated reasons.

br,
Imm


A little OT: are there some ressources how to get myself started with some volunteer work? I think I tried once already to check out the code, but then failed to import it in eclipse successfully :(
Comment 1 Sebb 2012-01-23 16:33:37 UTC 
It's the other way round for me, File Close uses the current filename, Window Close uses the dialogue.

It would be sensible if Window Close behaved the same as File/Close.
Comment 2 immanuel.hayden 2012-01-23 18:05:19 UTC 
Sorry if I got it the wrong way round (seems I wasn't concentrated at all when I wrote this and the other defect ... but it was my last half hour of work today, so maybe understandable ;))

Anyhow, as long as we can agree on which behaviour is better (for me its just saving the file) and that the two actions are different atm we don't have a problem :D
Comment 3 Philippe Mouawad 2012-01-25 22:36:28 UTC 
Date: Wed Jan 25 22:34:32 2012
New Revision: 1235972

URL: http://svn.apache.org/viewvc?rev=1235972&view=rev
Log:
Bug 52503 - Unify File->Close and Window close file saving behaviour

Modified:
   jmeter/trunk/src/core/org/apache/jmeter/gui/action/ExitCommand.java
   jmeter/trunk/xdocs/changes.xml
Comment 4 The ASF infrastructure team 2022-09-24 20:37:48 UTC 
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/2712