Bug 52725 - org.apache.jasper.compiler.JspUtil#getTagHandlerClassName() does not use org.apache.jasper.Constants.TAG_FILE_PACKAGE_NAME
Summary: org.apache.jasper.compiler.JspUtil#getTagHandlerClassName() does not use org....
Status: RESOLVED FIXED
Alias: None
Product: Tomcat 7
Classification: Unclassified
Component: Jasper (show other bugs)
Version: trunk
Hardware: All All
: P2 normal (vote)
Target Milestone: ---
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-21 11:28 UTC by Eugene Chung (TmaxSoft)
Modified: 2012-03-05 20:22 UTC (History)
1 user (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Chung (TmaxSoft) 2012-02-21 11:28:46 UTC 
In the class org.apache.jasper.compiler.JspUtil, its method 

    public static String getTagHandlerClassName(String path, String urn,
            ErrorDispatcher err) throws JasperException {
        ...
    }

uses the string constants directly like "org.apache.jsp.tag.web.", "org.apache.jsp.tag.meta.".

But you know there is TAG_FILE_PACKAGE_NAME field in the class org.apache.jasper.Constants.


The code should be adjusted like below :

Constants.TAG_FILE_PACKAGE_NAME + ".web"
Constants.TAG_FILE_PACKAGE_NAME + ".meta"
Comment 1 Eugene Chung (TmaxSoft) 2012-02-21 11:42:46 UTC 
I'm doing tasks that port Tomcat 7 Jasper to our WAS product these days. But I couldn't change the package name of tag classes without editing org.apache.jasper.compiler.JspUtil#getTagHandlerClassName().
Comment 2 Mark Thomas 2012-03-05 20:22:26 UTC 
Thanks for the report. Fixed in trunk and 7.0.x and will be included in 7.0.27 onwards.