Tomcat logs the start of the deployment directory, but doesn't log finish. I've created the small patch, which logs when the particular deployment is finished, with the deployment time. So output will be like this: Apr 10, 2014 4:26:17 PM org.apache.catalina.startup.HostConfig deployDirectory INFO: Deploying web application directory C:\AAA\Tools\apache-tomcat-7.0.52\webapps\aaa-admin .... Apr 10, 2014 4:31:10 PM org.apache.catalina.startup.HostConfig deployDirectory INFO: Deployment of web application directory C:\AAA\Tools\apache-tomcat-7.0.52\webapps\aaa-admin has finished in 292,516 ms.
Created attachment 31506 [details] Proposed patch
Comment on attachment 31506 [details] Proposed patch In reply to attachment 31506 [details] > if( log.isInfoEnabled() ) > + startTime = System.currentTimeMillis(); > log.info(sm.getString("hostConfig.deployDir", > dir.getAbsolutePath())); 1. The above change breaks the code, because of missing '{' after an 'if' above. > System.currentTimeMillis() - startTime 2. Boxing and unboxing have to be explicit, per our coding rules. 3. This covers only 'deployDirectory(..)' method. What about the others?
(In reply to Konstantin Kolinko from comment #2) > Comment on attachment 31506 [details] > Proposed patch > > In reply to attachment 31506 [details] > > > if( log.isInfoEnabled() ) > > + startTime = System.currentTimeMillis(); > > log.info(sm.getString("hostConfig.deployDir", > > dir.getAbsolutePath())); > > 1. The above change breaks the code, because of missing '{' after an 'if' > above. Fixed. > > System.currentTimeMillis() - startTime > > 2. Boxing and unboxing have to be explicit, per our coding rules. Fixed. > 3. This covers only 'deployDirectory(..)' method. What about the others? Done for deployDirectory, deployWAR and deployDescriptor methods.
Created attachment 31511 [details] Proposed patch - corrected
Created attachment 31512 [details] Proposed patch - corrected 2
Is it ok now?
Thanks for the report and the patch. This has been fixed in trunk for 8.0.6 and in 7.0.x for 7.0.54 onwards.