Bug 57637 - PersistentValve always causes a new session to be created
Summary: PersistentValve always causes a new session to be created
Status: RESOLVED FIXED
Alias: None
Product: Tomcat 9
Classification: Unclassified
Component: Catalina (show other bugs)
Version: unspecified
Hardware: All All
: P2 normal (vote)
Target Milestone: -----
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-25 16:00 UTC by Jeremy Boynes
Modified: 2015-02-26 19:42 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Boynes 2015-02-25 16:00:47 UTC 
When determining if a session should be persisted, PersistentValve calls getSessionInternal with no arguments which causes a new one to be allocated if none exists. It should pass false to avoid unnecessary sessions being allocated.

http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/PersistentValve.java?revision=1561138&view=markup#l131
Comment 1 Felix Schumacher 2015-02-25 21:16:07 UTC 
Fixed in trunk.
Comment 2 Felix Schumacher 2015-02-26 19:42:16 UTC 
Will be included in tomcat 8.0.21 and 7.0.60.