Bug 58424 - javaee tck fail(category=jsf, test name= jsfTldSignatureTest)
Summary: javaee tck fail(category=jsf, test name= jsfTldSignatureTest)
Status: RESOLVED FIXED
Alias: None
Product: Tomcat 8
Classification: Unclassified
Component: Jasper (show other bugs)
Version: 8.0.x-trunk
Hardware: PC Linux
: P2 normal (vote)
Target Milestone: ----
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-17 07:13 UTC by sungbae_yoon
Modified: 2015-09-17 13:44 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description sungbae_yoon 2015-09-17 07:13:23 UTC 
I've ported Japser into my JavaEE7 product.
When I ran tck, test failed.

com/sun/ts/tests/jsf/spec/webapp/tldsig/URLClient.java#jsfTldSignatureTest	Failed. Test case throws exception: [BaseUrlClient] null failed!  Check output for cause of failure.

This test compares TagLibraryInfos of jsf_core.tld file.
One is loaded from test's parser, the other is loaded from testee's parser code.

The test prints out like this even though tld file has value 'true'.
Taglibrary 'http://java.sun.com/jsf/core' FAILED
[http://java.sun.com/jsf/core:viewParam:id] - Mismatch on rtexpr value configuration - expected: true, received: false

I checked TldRuleSet code that is used to parse tld file and found out that
Jasper needs to trim body text in case of tld file which has element body like this
<rtexprvalue>
    true
</rtexprvalue>

TldRuleSet$GenericBooleanRule cannot convert this(\n    true\n) to true.

Plz, check this. Thanks.
Comment 1 Christopher Schultz 2015-09-17 13:44:43 UTC 
Fixed in trunk in r1703584.
Fixed in Tomcat 8 in r1703621. Will be in Tomcat 8.0.27.