Bug 59103 - HTTP Request Java Implementation: Change default "http.java.sampler.retries" to align it on HttpClient behaviour and make it meaningful
Summary: HTTP Request Java Implementation: Change default "http.java.sampler.retries" ...
Status: RESOLVED FIXED
Alias: None
Product: JMeter - Now in Github
Classification: Unclassified
Component: HTTP (show other bugs)
Version: 2.13
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-02 21:08 UTC by Philippe Mouawad
Modified: 2016-03-03 07:39 UTC (History)
1 user (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Mouawad 2016-03-02 21:08:43 UTC 
To align HttpClient with Java behaviour, I suggest that as for HttpClient, we switch this property to 0.

Property is by the way not greatly named as a value of 1 means 0 retry.

So we will fix the algorithm so that 0 means no retry.
Comment 1 Philippe Mouawad 2016-03-02 21:20:26 UTC 
Author: pmouawad
Date: Wed Mar  2 21:19:46 2016
New Revision: 1733369

URL: http://svn.apache.org/viewvc?rev=1733369&view=rev
Log:
Bug 59103 - HTTP Request Java Implementation: Change default "http.java.sampler.retries" to align it on HttpClient behaviour and make it meaningful
Bugzilla Id: 59103

Modified:
    jmeter/trunk/bin/jmeter.properties
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPJavaImpl.java
    jmeter/trunk/xdocs/changes.xml
Comment 2 Sebb 2016-03-02 23:23:07 UTC 
I think this needs more detailed documentation in the changes file.

It is an incompatibility.
Comment 3 Philippe Mouawad 2016-03-03 07:39:17 UTC 
Author: pmouawad
Date: Thu Mar  3 07:33:26 2016
New Revision: 1733419

URL: http://svn.apache.org/viewvc?rev=1733419&view=rev
Log:
Bug 59103 - HTTP Request Java Implementation: Change default "http.java.sampler.retries" to align it on HttpClient behaviour and make it meaningful
Improve Incompatible changes section for the property.
Bugzilla Id: 59103

Modified:
    jmeter/trunk/xdocs/changes.xml
Comment 4 The ASF infrastructure team 2022-09-24 20:38:03 UTC 
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/3875