Bug 59950 - Incorrect variables in upgradeHandler.pruneIncomplete log message
Summary: Incorrect variables in upgradeHandler.pruneIncomplete log message
Status: RESOLVED FIXED
Alias: None
Product: Tomcat 8
Classification: Unclassified
Component: Catalina (show other bugs)
Version: 8.5.x-trunk
Hardware: All All
: P2 trivial (vote)
Target Milestone: ----
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-05 13:57 UTC by Chris Sainty
Modified: 2016-08-09 16:41 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Sainty 2016-08-05 13:57:58 UTC
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/coyote/http2/LocalStrings.properties?view=markup#l107

The log message "upgradeHandler.pruneIncomplete" uses {0} twice instead of {0} and {1}.
So you can't see how many streams were not pruned.

You can see here how two variables are passed in - http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java?view=markup#l1016
Comment 1 Mark Thomas 2016-08-09 16:41:20 UTC
Thanks for the report.

Fixed in 9.0.x for 9.0.0-M10 and 8.5.x for 8.5.5 onwards.