Bug 1905

Summary:	mkdir has too few arguments
Product:	Spamassassin	Reporter:	Kevin A. McGrail <kmcgrail>
Component:	spamc/spamd	Assignee:	Theo Van Dinter <felicity>
Status:	RESOLVED FIXED
Severity:	normal	CC:	dev
Priority:	P5	Keywords:	backport
Version:	2.54
Target Milestone:	2.55
Hardware:	Other
OS:	other
Whiteboard:
Attachments:	suggested patch, adds a 0700 parameter

Description Kevin A. McGrail 2003-05-12 16:24:42 UTC

Under Perl 5.005.03, the new mkdir routine in spamd bombs.  I mentioned this in 
Bug 1904 but it should get it's own bug.

I believe it's a very very simple fix.

diff -u Mail-SpamAssassin-2.54-Fix/spamd/spamd.raw Mail-SpamAssassin-
2.54/spamd/spamd.raw
--- Mail-SpamAssassin-2.54-Fix/spamd/spamd.raw  Mon May 12 19:22:02 2003
+++ Mail-SpamAssassin-2.54/spamd/spamd.raw      Mon May 12 15:15:36 2003
@@ -872,7 +872,7 @@
     my $spam_conf_dir = $dir . '/.spamassassin';  #needed for AWL, Bayes, etc.
     if ( ! -d $spam_conf_dir )
     {
-       if ( mkdir($spam_conf_dir,0700) )
+       if ( mkdir $spam_conf_dir )
        {
           logmsg "info: created $spam_conf_dir for $username.";
        }

Comment 1 Theo Van Dinter 2003-05-18 13:26:46 UTC

Created attachment 967 [details]
suggested patch, adds a 0700 parameter

Comment 2 Theo Van Dinter 2003-05-18 13:27:33 UTC

giving it to myself ...

Comment 3 Daniel Quinlan 2003-05-18 14:00:21 UTC

OKAY: I suppose that's okay.

(770 would be fine for me since I'm using user-groups and a umask of 0002)

Comment 4 Theo Van Dinter 2003-05-18 14:02:11 UTC

Subject: Re: [SAdev]  mkdir has too few arguments

On Sun, May 18, 2003 at 02:00:21PM -0700, bugzilla-daemon@hughes-family.org wrote:
> (770 would be fine for me since I'm using user-groups and a umask of 0002)

I was going to use 777 since that's the default for 5.6.x, but the rest
of our mkdir calls in spamd is 700, so ... :|

Comment 5 Duncan Findlay 2003-05-18 16:58:59 UTC

OKAY

Comment 6 Theo Van Dinter 2003-05-18 17:18:55 UTC

applied to stable and head