|
SA Bugzilla – Full Text Bug Listing |
Summary: | [review] __OIMO_MSGID header pattern is not correct | ||
---|---|---|---|
Product: | Spamassassin | Reporter: | Mark Noyes <mark> |
Component: | Rules | Assignee: | Daryl C. W. O'Shea <spamassassin> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | dev |
Priority: | P3 | Keywords: | triage |
Version: | 3.0.0 | ||
Target Milestone: | 3.1.1 | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | ready | ||
Attachments: |
Sample email in mbx format that reproduces the problem
3.1 patch 3.1 patch |
Description
Mark Noyes
2005-10-29 05:08:04 UTC
Hum. Looks like it might be possible to optimize that pattern too. The ending [stuff]+\S+ is a pattern that could easily have N different boundaries and all be valid. Since the username probably doesn't start with - or _, maybe something like \w\S+ would be sufficient? Or maybe just \S? Mark, You flag this as "all" hardware and O/s, but version 2.0 of SA? Can you please let us know which version of MS Outlook 2000 this is? Can you send an email to me at RMSA@Menschel.net, from that Outlook 2k system, so I can attach a sample email with headers as an example we can test against? Thanks. Received requested email. SA version 3.0.x, Outlook version 9.0.0.2711. Will attach the email Created attachment 3220 [details]
Sample email in mbx format that reproduces the problem
I've tested some modifications to the rule (the originally posted rule was mis-copied, BTW): # original rule header T_OIMO_MSGID_0 MESSAGEID =~ /^<[A-P]{26}A[AB]\.[-_\w.]+\@\S+>$/m # original rule with what I assume was meant to be an escaped period header T_OIMO_MSGID_1 MESSAGEID =~ /^<[A-P]{26}A[AB]\.[-\w\.]+\@\S+>$/m # modified rule without escaped period header T_OIMO_MSGID_2 MESSAGEID =~ /^<[A-P]{26}A[ABC]\.[-\w.]+\@\S+>$/m # modified rule with escaped period header T_OIMO_MSGID_3 MESSAGEID =~ /^<[A-P]{26}A[ABC]\.[-\w\.]+\@\S+>$/m Mass-check results: http://buildbot.spamassassin.org/ruleqa/ruleqa?s_defcorpus=on&daterev=20051117-r345134-n&rule=%2F%5ET_OIMO&s_zero=on&s_detail=checked+&g=Change T_OIMO_MSGID_3 has a better S/O, hitting lots more ham with a negligible increase in spam hits. Created attachment 3257 [details] 3.1 patch trunk r345404 +1 Created attachment 3272 [details] 3.1 patch duh! dots aren't character class metacharacters This patch removes the extraneous backslash. It doesn't affect mass-check results. trunk r348610 +1 +1 Thanks Duncan! Sending rules/20_ratware.cf Transmitting file data . Committed revision 372069. |