Bug 7975

Summary:	Util.pm, sub domain_to_search_list, code reordering
Product:	Spamassassin	Reporter:	Michael Storz <sa-mst>
Component:	Libraries	Assignee:	SpamAssassin Developer Mailing List <dev>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	apache, sa-mst
Priority:	P2
Version:	4.0.0
Target Milestone:	Undefined
Hardware:	All
OS:	All
Whiteboard:
Attachments:	suggestion for code reorder

Description Michael Storz 2022-04-19 17:02:41 UTC

@Henric: I like how you rewrote the subroutine domain_to_search_list. It is elegant, short and fast. That's how code should be. In addition, I would suggest to use the power of return to simplify control structures, see my suggestion.

Comment 1 Michael Storz 2022-04-19 17:04:24 UTC

Created attachment 5775 [details]
suggestion for code reorder

Comment 2 Henrik Krohns 2022-04-20 02:50:21 UTC

Appreciate your reviews

Sending        trunk/lib/Mail/SpamAssassin/Util.pm
Transmitting file data .done
Committing transaction...
Committed revision 1900045.