7975 – Util.pm, sub domain_to_search_list, code reordering

Bug 7975 - Util.pm, sub domain_to_search_list, code reordering

Summary: Util.pm, sub domain_to_search_list, code reordering

Status:	RESOLVED FIXED

Alias:	None

Product:	Spamassassin
Classification:	Unclassified
Component:	Libraries (show other bugs)
Version:	4.0.0
Hardware:	All All

Importance:	P2 enhancement
Target Milestone:	Undefined
Assignee:	SpamAssassin Developer Mailing List

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2022-04-19 17:02 UTC by Michael Storz
Modified:	2022-04-20 02:50 UTC (History)
CC List:	2 users (show)

Attachment	Type	Modified	Status	Actions	Submitter/CLA Status
suggestion for code reorder	text/plain			None	Michael Storz
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michael Storz 2022-04-19 17:02:41 UTC

@Henric: I like how you rewrote the subroutine domain_to_search_list. It is elegant, short and fast. That's how code should be. In addition, I would suggest to use the power of return to simplify control structures, see my suggestion.

Comment 1 Michael Storz 2022-04-19 17:04:24 UTC

Created attachment 5775 [details]
suggestion for code reorder

Comment 2 Henrik Krohns 2022-04-20 02:50:21 UTC

Appreciate your reviews

Sending        trunk/lib/Mail/SpamAssassin/Util.pm
Transmitting file data .done
Committing transaction...
Committed revision 1900045.