ASF Bugzilla – Attachment 27259 Details for
Bug 51476
[PATCH] Fixes broken cell formatting for boolean values; fixes html conversion for XSSF
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
PATCH file in txt from ant script, the tar.gz one was empty for some reason
patch.txt (text/plain), 1.85 KB, created by
Fabio Corubolo
on 2011-07-05 15:33:59 UTC
(
hide
)
Description:
PATCH file in txt from ant script, the tar.gz one was empty for some reason
Filename:
MIME Type:
Creator:
Fabio Corubolo
Created:
2011-07-05 15:33:59 UTC
Size:
1.85 KB
patch
obsolete
>Index: src/java/org/apache/poi/ss/format/CellFormat.java >=================================================================== >--- src/java/org/apache/poi/ss/format/CellFormat.java (revision 1142957) >+++ src/java/org/apache/poi/ss/format/CellFormat.java (working copy) >@@ -212,7 +212,7 @@ > case Cell.CELL_TYPE_BLANK: > return apply(""); > case Cell.CELL_TYPE_BOOLEAN: >- return apply(c.getStringCellValue()); >+ return apply(Boolean.toString(c.getBooleanCellValue())); > case Cell.CELL_TYPE_NUMERIC: > return apply(c.getNumericCellValue()); > case Cell.CELL_TYPE_STRING: >@@ -254,7 +254,7 @@ > case Cell.CELL_TYPE_BLANK: > return apply(label, ""); > case Cell.CELL_TYPE_BOOLEAN: >- return apply(label, c.getStringCellValue()); >+ return apply(Boolean.toString(c.getBooleanCellValue())); > case Cell.CELL_TYPE_NUMERIC: > return apply(label, c.getNumericCellValue()); > case Cell.CELL_TYPE_STRING: >Index: src/examples/src/org/apache/poi/ss/examples/html/XSSFHtmlHelper.java >=================================================================== >--- src/examples/src/org/apache/poi/ss/examples/html/XSSFHtmlHelper.java (revision 1142957) >+++ src/examples/src/org/apache/poi/ss/examples/html/XSSFHtmlHelper.java (working copy) >@@ -58,7 +58,11 @@ > // support it will ignore the rgba specification and stick with the > // solid color, which is declared first > out.format(" %s: #%02x%02x%02x;%n", attr, rgb[0], rgb[1], rgb[2]); >+ byte[] argb = color.getARgb(); >+ if (argb == null) { >+ return; >+ } > out.format(" %s: rgba(0x%02x, 0x%02x, 0x%02x, 0x%02x);%n", attr, >- rgb[0], rgb[1], rgb[2], rgb[3]); >+ argb[3], argb[0], argb[1], argb[2]); > } > } >\ No newline at end of file
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 51476
:
27258
| 27259