ASF Bugzilla – Attachment 34674 Details for
Bug 60643
HTTP(S) Test Script Recorder doesn't correctly handle restart or start after stop
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch fixing the issue
BUG_60643.patch (text/plain), 2.94 KB, created by
UbikLoadPack support
on 2017-01-25 14:37:37 UTC
(
hide
)
Description:
Patch fixing the issue
Filename:
MIME Type:
Creator:
UbikLoadPack support
Created:
2017-01-25 14:37:37 UTC
Size:
2.94 KB
patch
obsolete
>Index: src/core/org/apache/jmeter/reporters/ResultCollector.java >=================================================================== >--- src/core/org/apache/jmeter/reporters/ResultCollector.java (revision 1779701) >+++ src/core/org/apache/jmeter/reporters/ResultCollector.java (working copy) >@@ -63,7 +63,31 @@ > */ > public class ResultCollector extends AbstractListenerElement implements SampleListener, Clearable, Serializable, > TestStateListener, Remoteable, NoThreadClone { >+ /** >+ * Keep track of the file writer and the configuration, >+ * as the instance used to close them is not the same as the instance that creates >+ * them. This means one cannot use the saved PrintWriter or use getSaveConfig() >+ */ >+ private static class FileEntry{ >+ final PrintWriter pw; >+ final SampleSaveConfiguration config; >+ FileEntry(PrintWriter _pw, SampleSaveConfiguration _config){ >+ pw =_pw; >+ config = _config; >+ } >+ } >+ >+ private static final class ShutdownHook implements Runnable { > >+ @Override >+ public void run() { >+ log.info("Shutdown hook started"); >+ synchronized (LOCK) { >+ flushFileOutput(); >+ } >+ log.info("Shutdown hook ended"); >+ } >+ } > private static final Logger log = LoggingManager.getLoggerForClass(); > > private static final long serialVersionUID = 233L; >@@ -110,19 +134,6 @@ > //@GuardedBy("LOCK") > private static Thread shutdownHook; > >- /* >- * Keep track of the file writer and the configuration, >- * as the instance used to close them is not the same as the instance that creates >- * them. This means one cannot use the saved PrintWriter or use getSaveConfig() >- */ >- private static class FileEntry{ >- final PrintWriter pw; >- final SampleSaveConfiguration config; >- FileEntry(PrintWriter _pw, SampleSaveConfiguration _config){ >- pw =_pw; >- config = _config; >- } >- } > > /** > * The instance count is used to keep track of whether any tests are currently running. >@@ -137,24 +148,15 @@ > > private transient volatile PrintWriter out; > >+ /** >+ * Is a test running ? >+ */ > private volatile boolean inTest = false; > > private volatile boolean isStats = false; > > /** the summarizer to which this result collector will forward the samples */ > private volatile Summariser summariser; >- >- private static final class ShutdownHook implements Runnable { >- >- @Override >- public void run() { >- log.info("Shutdown hook started"); >- synchronized (LOCK) { >- flushFileOutput(); >- } >- log.info("Shutdown hook ended"); >- } >- } > > /** > * No-arg constructor. >@@ -633,6 +635,7 @@ > } > } > files.clear(); >+ out = null; > } > > /**
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 60643
: 34674