| Summary: | does not log request completion time even with #define I_INSIST_ON_EXTRA_CYCLES_FOR_CLF_COMPLIANCE | ||
|---|---|---|---|
| Product: | Apache httpd-2 | Reporter: | Alois Treindl <alois> |
| Component: | mod_log_config | Assignee: | Apache HTTPD Bugs Mailing List <bugs> |
| Status: | CLOSED FIXED | ||
| Severity: | normal | Keywords: | PatchAvailable |
| Priority: | P3 | ||
| Version: | 2.0.46 | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
Fix committed to 2.1-dev, and I'll propose it for merging into stable branch for 2.0.next. Thanks for the fix, and thanks for using Apache httpd! |
file modules/loggers/mod_log_config.c has a special #define I_INSIST_ON_EXTRA_CYCLES_FOR_CLF_COMPLIANCE which has the purpose that logfile timestamps log the completion time of a request, and not the new 2.0 default, which is the begin time of a request. This #define does not work for Customlog, because of a bug: r->request_time is used anyway! The patch is @@ -556,7 +548,7 @@ char sign; int timz; - ap_explode_recent_localtime(&xt, r->request_time); + ap_explode_recent_localtime(&xt, request_time); timz = xt.tm_gmtoff; if (timz < 0) { timz = -timz;