| Summary: | Code that uses BaseScriptingEnvironment.createWindow() now won't compile | ||
|---|---|---|---|
| Product: | Batik - Now in Jira | Reporter: | Cameron McCormack <cam> |
| Component: | Bridge | Assignee: | Batik Developer's Mailing list <batik-dev> |
| Status: | NEW --- | ||
| Severity: | normal | CC: | gwadej, helder.magalhaes |
| Priority: | P2 | ||
| Version: | 1.8 | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
|
Description
Cameron McCormack
2009-01-04 17:35:20 UTC
(In reply to comment #0) > In r665947, BaseScriptingEnvironment.createWindow() was made protected. Some > published code, such as the example at > http://xmlgraphics.apache.org/batik/using/scripting/java.html, uses this method > and assumes it's public. Breaking documentation sample code it's always unfortunate... :-| > The method should be made public once again, but rewritten so that a single > Window object only ever exists (so it will act like the getWindow() method does > now). A new, different protected method that subclasses should override to > provide a concrete Window object should be used. I'm CC'ing G. Wade Johnson as I have a feeling this may also have something to do with the Window improvements tracked in issue 46072 (in revision 712954) and he might be the right person to provide a patch, even if preliminary. ;-) |