Bug 52740

Summary:	An incomplete fix for the resource leak bug in Javadoc.java
Product:	Ant	Reporter:	lianggt08
Component:	Core	Assignee:	Ant Notifications List <notifications>
Status:	RESOLVED FIXED
Severity:	minor	CC:	jglick
Priority:	P2
Version:	1.8.2
Target Milestone:	1.9.0
Hardware:	All
OS:	All

Description lianggt08 2012-02-23 07:06:36 UTC

The fix revision 272583 was aimed to remove resource leak bugs on the PrintWriter object "srcListWriter" (created in line 1684) in the method "execute"of the file 
"/ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Javadoc.java" , but it is incomplete.

There are some problems: 
1. when "srcListWriter" isn't created successfully but the temp FileWriter object is created successfully (at line 1685), the temp FileWriter object will be leaked. 

The best way to close such resource objects is putting such close operations for all resource objects in the finaly block of a try-catch-finally structure and then putting all other code in a try block.

The problem still exists in the head revision (the temp FileWriter object created at 1723 can be leaked).

Comment 1 Jesse Glick 2012-02-27 21:43:56 UTC

Committed revision 1294345.