Summary: | Summariser should be enabled by default in Non GUI mode | ||
---|---|---|---|
Product: | JMeter - Now in Github | Reporter: | Philippe Mouawad <p.mouawad> |
Component: | Main | Assignee: | JMeter issues mailing list <issues> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | p.mouawad |
Priority: | P2 | ||
Version: | 2.9 | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All |
Description
Philippe Mouawad
2013-08-31 20:35:09 UTC
I think this should be discussed on the DEV list first please. Keep this issue open until the discussion is resolved. I propose changing the following: - summariser.interval => 30 s in org.apache.jmeter.JMeter.runNonGui(String, String, boolean, String) , change JMeterUtils.getPropDefault("summariser.name", "") to JMeterUtils.getPropDefault("summariser.name", "DefaultNonGuiSummariser") I no objection, I will be commiting this tomorrow evening. (In reply to Philippe Mouawad from comment #2) > I propose changing the following: > - summariser.interval => 30 s Why? > in org.apache.jmeter.JMeter.runNonGui(String, String, boolean, String) , > change JMeterUtils.getPropDefault("summariser.name", "") to > JMeterUtils.getPropDefault("summariser.name", "DefaultNonGuiSummariser") Not a good idea to have such a long name as it can cause unnecessary wrapping. That's why the default is empty. (In reply to Sebb from comment #3) > (In reply to Philippe Mouawad from comment #2) > > I propose changing the following: > > - summariser.interval => 30 s > > Why? > Because 180s seems to me a long interval to react to test event > > in org.apache.jmeter.JMeter.runNonGui(String, String, boolean, String) , > > change JMeterUtils.getPropDefault("summariser.name", "") to > > JMeterUtils.getPropDefault("summariser.name", "DefaultNonGuiSummariser") > > Not a good idea to have such a long name as it can cause unnecessary > wrapping. > That's why the default is empty. But if we keep it empty it will not be enabled, or do I misunderstand something ? Any feedback on this ? (In reply to Philippe Mouawad from comment #4) > (In reply to Sebb from comment #3) > > (In reply to Philippe Mouawad from comment #2) > > > I propose changing the following: > > > - summariser.interval => 30 s > > > > Why? > > > Because 180s seems to me a long interval to react to test event > > > > in org.apache.jmeter.JMeter.runNonGui(String, String, boolean, String) , > > > change JMeterUtils.getPropDefault("summariser.name", "") to > > > JMeterUtils.getPropDefault("summariser.name", "DefaultNonGuiSummariser") > > > > Not a good idea to have such a long name as it can cause unnecessary > > wrapping. > > That's why the default is empty. Ignore that. > But if we keep it empty it will not be enabled, or do I misunderstand > something ? No, you are correct, but using a long name causes unnecessary word-wrap Date: Thu Dec 12 21:28:40 2013 New Revision: 1550536 URL: http://svn.apache.org/r1550536 Log: Bug 55512 - Summariser should be enabled by default in Non GUI mode Bugzilla Id: 55512 Modified: jmeter/trunk/bin/jmeter.properties jmeter/trunk/src/core/org/apache/jmeter/JMeter.java jmeter/trunk/src/core/org/apache/jmeter/reporters/Summariser.java jmeter/trunk/xdocs/changes.xml The jmeter.properties file still says: # Define the following property to automatically start a summariser with that name # (applies to non-GUI mode only) #summariser.name=summary This implies that the summariser won't be started unless the property is defined, however that is no longer the case, because the code defaults to summariser.name=summary. We can either: 1) fix the properties file, or 2) revert the code change and enable the property in the property file. It's now a bit awkward to disable the summariser, one has to put the following in the file: summariser.name= Luckily leading spaces and tabs are ignored when the properties file is parsed, so invisble spaces won't start the summariser, but it still looks wrong to me. Therefore I favour option 2. Any objections? No objections for me. URL: http://svn.apache.org/viewvc?rev=1723203&view=rev Log: Summariser should be enabled by default in Non GUI mode Revert the changes made in r1550536 and just enable via jmeter.properties Bugzilla Id: 55512 Modified: jmeter/trunk/bin/jmeter.properties jmeter/trunk/src/core/org/apache/jmeter/JMeter.java jmeter/trunk/src/core/org/apache/jmeter/reporters/Summariser.java Author: pmouawad Date: Wed Jan 6 21:03:36 2016 New Revision: 1723411 URL: http://svn.apache.org/viewvc?rev=1723411&view=rev Log: [Bug 55512] Summariser should be enabled by default in Non GUI mode Restore 30 seconds as interval Bugzilla Id: 55512 Modified: jmeter/trunk/bin/jmeter.properties jmeter/trunk/src/core/org/apache/jmeter/reporters/Summariser.java This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/3221 |