| Summary: | Issue with XML version in JTL files | ||
|---|---|---|---|
| Product: | JMeter - Now in Github | Reporter: | Andrey Pokhilko <apc4> |
| Component: | Main | Assignee: | JMeter issues mailing list <issues> |
| Status: | REOPENED --- | ||
| Severity: | minor | CC: | p.mouawad |
| Priority: | P2 | ||
| Version: | 3.0 | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | 58679 | ||
| Bug Blocks: | |||
|
Description
Andrey Pokhilko
2016-08-11 10:09:21 UTC
Date: Thu Aug 11 10:27:45 2016 New Revision: 1755929 URL: http://svn.apache.org/viewvc?rev=1755929&view=rev Log: Bug 59973 - Issue with XML version in JTL files Modified: jmeter/trunk/bin/testfiles/BatchTestLocal.xml jmeter/trunk/bin/testfiles/BatchTestLocalRemote.xml jmeter/trunk/bin/testfiles/Bug47165.xml jmeter/trunk/bin/testfiles/Bug50898.xml jmeter/trunk/bin/testfiles/Bug52310.xml jmeter/trunk/bin/testfiles/Bug52968.xml jmeter/trunk/bin/testfiles/Bug54685.xml jmeter/trunk/bin/testfiles/Bug55375.xml jmeter/trunk/bin/testfiles/Bug56243.xml jmeter/trunk/bin/testfiles/Bug56811.xml jmeter/trunk/bin/testfiles/HTMLParserTestFile_2.xml jmeter/trunk/bin/testfiles/TEST_HTTPS.xml jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java jmeter/trunk/xdocs/changes.xml The first commits introduce a regression I think. With the trunk version, if I try to open a JTL file (recorded by trunk version too) into a listenr, I have this error message (the listener dont display the results) : 2016/08/17 10:11:28 WARN - jmeter.reporters.ResultCollector: Failed to load /directory/Results-20160816-1625.jtl using XStream. Error was: com.thoughtworks.xstream.io.StreamException: : only 1.0 is supported as <?xml version not '1.1' (position: START_DOCUMENT seen <?xml version="1.1"... @1:19) Funny... Xstream writes XML 1.1, but requires 1.0 declaration... I'll investigate it more Milamber, which version of XStream library do you have? I have 1.4.8 and don't experience this. Also, I tried searching for this kind of error message in XStream sources of 1.4.8 and did not find it. The version from the trunk: xstream-1.4.8.jar Test case : - Compile JMeter from trunk (ant distribution) - unzip the binary, launch JMeter (with Java8) - Create a simple test plan: Thread Group |-- HTTP request |-- View Results Tree with a file to record into JTL (inside Configure button select all options) - Run - Close JMeter and reopen - Add a View Results Tree, a try to open the jtl file from the simple test. Thanks for the reproducing case. I have investigated it and found that issue is in xpp3 library we use. It is 10 years old and has xml 1.0 requirement hardcoded into it. There are no newer versions of this library that could load XML 1.1. So it's a deadlock: we write XML 1.1 as body, we state that it's 1.0 in header because reading flow is unable to accept 1.1 header. However, it perfectly eats 1.1 body, which means that xpp3 does not conform to XML standard. From their FAQ (http://x-stream.github.io/faq.html#XML_control_char) I can assume that the only way is to rollback my changes. Also, we should document somewhere here (http://jmeter.apache.org/usermanual/listeners.html#xmlformat2.1) that JTL and JMX files produced by JMeter do not conform XML 1.0 standard and cannot be read by strict parsers. Users should be aware of this issue. I have reverted the modifications (In reply to Andrey Pokhilko from comment #7) > Thanks for the reproducing case. I have investigated it and found that issue > is in xpp3 library we use. It is 10 years old and has xml 1.0 requirement > hardcoded into it. There are no newer versions of this library that could > load XML 1.1. > So it's a deadlock: we write XML 1.1 as body, we state that it's 1.0 in > header because reading flow is unable to accept 1.1 header. However, it > perfectly eats 1.1 body, which means that xpp3 does not conform to XML > standard. > > From their FAQ (http://x-stream.github.io/faq.html#XML_control_char) I can > assume that the only way is to rollback my changes. Also, we should document > somewhere here > (http://jmeter.apache.org/usermanual/listeners.html#xmlformat2.1) that JTL > and JMX files produced by JMeter do not conform XML 1.0 standard and cannot > be read by strict parsers. Users should be aware of this issue. See this Bug 58679 related to this issue, this would be the final fix. Date: Wed Aug 17 20:11:30 2016 New Revision: 1756681 URL: http://svn.apache.org/viewvc?rev=1756681&view=rev Log: Bug 59973 - revert all modifications Modified: jmeter/trunk/bin/testfiles/BatchTestLocal.xml jmeter/trunk/bin/testfiles/BatchTestLocalRemote.xml jmeter/trunk/bin/testfiles/Bug47165.xml jmeter/trunk/bin/testfiles/Bug50898.xml jmeter/trunk/bin/testfiles/Bug52310.xml jmeter/trunk/bin/testfiles/Bug52968.xml jmeter/trunk/bin/testfiles/Bug54685.xml jmeter/trunk/bin/testfiles/Bug55375.xml jmeter/trunk/bin/testfiles/Bug56243.xml jmeter/trunk/bin/testfiles/Bug56811.xml jmeter/trunk/bin/testfiles/HTMLParserTestFile_2.xml jmeter/trunk/bin/testfiles/TEST_HTTPS.xml jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java jmeter/trunk/xdocs/changes.xml Date: Wed Aug 17 20:24:21 2016 New Revision: 1756682 URL: http://svn.apache.org/viewvc?rev=1756682&view=rev Log: Bug 59973 - document non-standard XML in docs and code Modified: jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java jmeter/trunk/xdocs/usermanual/component_reference.xml This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/4056 |