Bug 65235

Summary:	Mismatch between RemoteIpValve documentation and source code
Product:	Tomcat 9	Reporter:	Konstantin Kolinko <knst.kolinko>
Component:	Catalina	Assignee:	Tomcat Developers Mailing List <dev>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	P2
Version:	9.0.45
Target Milestone:	-----
Hardware:	PC
OS:	All

Description Konstantin Kolinko 2021-04-12 14:51:28 UTC

Reviewing the commit that implemented bug 57665,
https://github.com/apache/tomcat/commit/67c3af97230135af8f6f7566c77a79a69722a713

1. The documentation (webapps/docs/config/valve.xml) talks about attribute "changeLocalHost",  but the actual name of the attribute is "changeLocalName"

2. JMX bean descriptor (java/org/apache/catalina/valves/mbeans-descriptors.xml) has not been updated.

Comment 1 Mark Thomas 2021-04-16 11:47:10 UTC

Fixed in:
- 10.0.x for 10.0.6 onwards
- 9.0.x for 9.0.46 onwards
- 8.5.x for 8.5.66 onwards
- 7.0.x for 7.0.109 onwards