Bug 65235 - Mismatch between RemoteIpValve documentation and source code
Summary: Mismatch between RemoteIpValve documentation and source code
Status: RESOLVED FIXED
Alias: None
Product: Tomcat 9
Classification: Unclassified
Component: Catalina (show other bugs)
Version: 9.0.45
Hardware: PC All
: P2 normal (vote)
Target Milestone: -----
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-12 14:51 UTC by Konstantin Kolinko
Modified: 2021-04-16 11:47 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Kolinko 2021-04-12 14:51:28 UTC 
Reviewing the commit that implemented bug 57665,
https://github.com/apache/tomcat/commit/67c3af97230135af8f6f7566c77a79a69722a713

1. The documentation (webapps/docs/config/valve.xml) talks about attribute "changeLocalHost",  but the actual name of the attribute is "changeLocalName"

2. JMX bean descriptor (java/org/apache/catalina/valves/mbeans-descriptors.xml) has not been updated.
Comment 1 Mark Thomas 2021-04-16 11:47:10 UTC 
Fixed in:
- 10.0.x for 10.0.6 onwards
- 9.0.x for 9.0.46 onwards
- 8.5.x for 8.5.66 onwards
- 7.0.x for 7.0.109 onwards